Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all plugins for better maintenance #38

Open
odyssey4me opened this issue May 1, 2020 · 2 comments
Open

Refactor all plugins for better maintenance #38

odyssey4me opened this issue May 1, 2020 · 2 comments

Comments

@odyssey4me
Copy link
Collaborator

SUMMARY

Each of the modules are independent bits of code, but we could refactor them all to use common objects, methods, etc which would make their implementations more consistent and easier to maintain.

There are also some great ideas and samples in ansible/ansible#27905 which are worth looking at.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME
ADDITIONAL INFORMATION
@simsiem
Copy link

simsiem commented Nov 2, 2020

Hi odyssey4me,

because of the issue #47, I stumbled across this issue.

I wonder what is the status or plan here? Should we fix #47 or do we have some joint capacity to rewrite the network plugin?

@odyssey4me
Copy link
Collaborator Author

I would sincerely love some help to work on refactoring. I'm hoping to make some time to get to it, but I'm sensitive to the fact that any refactoring should involve ensuring decent test coverage first. If you're able to help with that, then it'd go a long way to improving the quality and maintainability of the modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants