parted: support fs_type

[ilpianista]

Closes #135

SUMMARY

Allow to customize the file system type for parted.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

parted

[ilpianista]

This has been migrated from ansible/ansible#47879

[ansibullbot]

cc @ColOfAbRiX @MorrisA @bcoca @d-little @flynn1973 @gforster @kairoaraujo @marvin-sinister @mator @molekuul @ramooncamacho @wtcross
click here for bot help

[Andersson007]

@ilpianista thanks for the PR!
In addition, would be also good to see an example with the new parameter in the EXAMPLE block.

[Andersson007]

@ColOfAbRiX hi, as the module's author could you please look

[Andersson007]

and we need a changelog fragment https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs
examples:
https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

[Andersson007]

if you agree to make the parameter optional, after changing this, feel free to create a new doc pr about part_type, ... and mention me please for reviweing. Thanks for the PR!

[Andersson007]

@ilpianista CI fails because of this line

plugins/modules/system/parted.py:623:29: SyntaxError: f"{fs_type} " if fs_type is not None else '',

this code below should work

>>> f_type = 'ext4'
>>> msg = '%s %s%s %s' % ('one', '%s ' % f_type if f_type is not None else '', 'two', 'three')
>>> print(msg)
one ext4 two three
>>> f_type = None
>>> msg = '%s %s%s %s' % ('one', '%s ' % f_type if f_type is not None else '', 'two', 'three')
>>> print(msg)
one two three

[ansibullbot]

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

plugins/modules/system/parted.py:623:29: SyntaxError: f"{fs_type} " if fs_type is not None else '',

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

plugins/modules/system/parted.py:623:29: SyntaxError: f"{fs_type} " if fs_type is not None else '',

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

plugins/modules/system/parted.py:623:29: SyntaxError: f"{fs_type} " if fs_type is not None else '',

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

plugins/modules/system/parted.py:623:29: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

plugins/modules/system/parted.py:623:29: traceback: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

plugins/modules/system/parted.py:623:29: traceback: SyntaxError: invalid syntax

click here for bot help

[Andersson007]

LGTM
shipit

[Andersson007]

Let's wait @felixfontein 's confirmation

[Andersson007]

bot_status

[ansibullbot]

Components

changelogs/fragments/221-parted-fs_type-parameter.yml
support: core
maintainers:

plugins/modules/system/parted.py
support: community
maintainers: ColOfAbRiX MorrisA bcoca d-little flynn1973 gforster marvin-sinister mator molekuul ramooncamacho wtcross

tests/unit/plugins/modules/system/test_parted.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

[Andersson007]

merged into master

[Andersson007]

@ilpianista @felixfontein thank you!
@ilpianista feel free to create a PR to improve the documentation in part of those options we discussed (which make sense to be passed only if a partition does not exist). And feel free to mention me there