docker_container: add device_requests option #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
cloud
community_review
docker
feature
|
CC @ei-grad @ssidorenko @mbigras @pete0emerson @Samh57 @xywsxp @tizz98 @bingzhangdai @pommedeterresautee since you all liked ansible/ansible#65748 or ansible/ansible#65748 (comment). Please test this, since I don't really have the ability to do so, and I guess you have :) |
|
I've added an example. I won't add check_mode tests for this option, since we don't do it for any other option either, as it would put a too large strain on CI resources. The docker_container tests are one of the most extensive tests already (over 650 tests) and run for 5-7 minutes (not counting setup). Also, the way the module is implemented makes additional check_mode tests for every option superfluous :) |
Andersson007
approved these changes
Oct 20, 2020
felixfontein
added
backport-1
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Oct 27, 2020
* docker_container: add device_requests option. * Fix copy'n'paste mistake. * Fix failure test. * Added example. * Adjust tense. (cherry picked from commit 8670eff)
felixfontein
added a commit
that referenced
this pull request
Oct 27, 2020
* docker_container: add device_requests option. * Fix copy'n'paste mistake. * Fix failure test. * Added example. * Adjust tense. (cherry picked from commit 8670eff) Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes ansible/ansible#65748.
Unfortunately it is hard to test this in CI, since we don't have special hardware and docker runtimes installed. The tests are therefore very minimalistic and don't really test something.
ISSUE TYPE
COMPONENT NAME
docker_container