Prevent RCE via inventory plugins

[felixfontein]

SUMMARY

Fixing a potential RCE when using the inventory plugins.

Ref: https://www.die-welt.net/2024/03/remote-code-execution-in-ansible-dynamic-inventory-plugins/
Ref: https://forum.ansible.com/t/remote-code-execution-in-ansible-dynamic-inventory-plugins/4332/3

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

inventory plugins

[felixfontein]

TIL: don't make ansible_connection unsafe. Some versions of ansible-core won't like it.

[felixfontein]

(In this case it's OK anyway since that variable is set to a fixed string. So nothing nefarious can happen this way.)

[patchback]

Backport to stable-2: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply bf1281a on top of patchback/backports/stable-2/bf1281ae7fd7ce41ecaec2ca05c5b54d913d4298/pr-815

Backporting merged PR #815 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/community.docker.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-2/bf1281ae7fd7ce41ecaec2ca05c5b54d913d4298/pr-815 upstream/stable-2

4. Now, cherry-pick PR Prevent RCE via inventory plugins #815 contents into that branch:

   $ git cherry-pick -x bf1281ae7fd7ce41ecaec2ca05c5b54d913d4298

   If it'll yell at you with something like fatal: Commit bf1281ae7fd7ce41ecaec2ca05c5b54d913d4298 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x bf1281ae7fd7ce41ecaec2ca05c5b54d913d4298

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Prevent RCE via inventory plugins #815 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-2/bf1281ae7fd7ce41ecaec2ca05c5b54d913d4298/pr-815

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@markuman thanks again for reviewing this!