Fix IPv6 zone handling

[felixfontein]

SUMMARY

Fixes #65. The same problem also appears in docker_network's CIDR validation. I don't know whether Docker supports zones here, but I don't see why we should restrict to non-zone CIDRs.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

docker_container
docker_network

[WojciechowskiPiotr]

Is there any way we can test IPv6 zones in integration tests?

[felixfontein]

@WojciechowskiPiotr probably not in a sane way. I'm not sure which values are actually valid for it, and it probably depends on the system running the docker daemon, which at least in the dockerized tests we have no access to.

[WojciechowskiPiotr]

@WojciechowskiPiotr probably not in a sane way. I'm not sure which values are actually valid for it, and it probably depends on the system running the docker daemon, which at least in the dockerized tests we have no access to.

Did you manage to manually test the patch?

[felixfontein]

No. I only tested the regex itself. I'm hoping that @kristof-mattei could try it out.

[WojciechowskiPiotr]

No. I only tested the regex itself. I'm hoping that @kristof-mattei could try it out.

Patch looks fine, but let's test properly it before merging

[kristof-mattei]

@WojciechowskiPiotr I'd love to test this, but any pointers how?

[felixfontein]

@kristof-mattei you can use the way described here: https://docs.ansible.com/ansible/devel/user_guide/collections_using.html#installing-a-collection-from-a-git-repository Here, it would beansible-galaxy collection install git+https://github.com/felixfontein/community.docker.git,ipv6-zones. Just make sure to eventually delete the manually installed collection, because otherwise it will hide updated versions of the collections installed with Ansible (if you are using Ansible 2.10).

Alternatively (if you don't mind working with git) you could use the way described here (https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#contributing-to-collections, third paragraph+). You need to check out the ipv6-zones branch of https://github.com/felixfontein/community.docker/.

[felixfontein]

@kristof-mattei did you had a chance to test this yet?

[felixfontein]

I managed to test it for docker_container, it seems to work fine. I couldn't test it for docker_network (resp. Docker daemon always complained about an invalid CIDR), so I removed the change for that one.

[felixfontein]

As Docker daemon seems to allow a random zone, we're able to (somewhat) test this in CI.

[Andersson007]

LGTM

[felixfontein]

@WojciechowskiPiotr @Andersson007 thanks for reviewing this!