docker_container: deprecate current behavior when specifying all with other port mappings #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Regarding #8, deprecate the current behavior when
published_portscontains port mappings next to the special valueall.The deprecation meesage informs user that the current behavior (which they might not be aware of) will change in a breaking way, namely either it will be forbidden, or properly handled (like Docker CLI) in community.docker 2.0.0.
I didn't want to promise that I implement it properly, that's why I keep the possibliity to simply forbid it. In that case, specifying both
alland port mappings will make the module fail. This can be changed anytime later (would be a new feature at that point).ISSUE TYPE
COMPONENT NAME
docker_container