Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cap_add and cap_drop handling for docker_swarm_service #294

Merged
merged 7 commits into from
Feb 12, 2022
Merged

Implement cap_add and cap_drop handling for docker_swarm_service #294

merged 7 commits into from
Feb 12, 2022

Conversation

andrasmaroy
Copy link
Contributor

SUMMARY

With the 5.0.3 release of Docker SDK for Python support was added for these parameters for swarm services. With that adding support in Ansible should be as simple as exposing these variables for the module. That's what's done in this change.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_swarm_service

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@andrasmaroy
Copy link
Contributor Author

I'm a bit confused about these CI failures, the errors seem unrelated to me, am I just not seeing the full picture?

@felixfontein
Copy link
Collaborator

felixfontein commented Feb 6, 2022

The CI errors are caused by your changes, see my explanation here: #294 (comment) Capabilities for swarm services need both a new enough Docker SDK for Python version and a new enough API version. The former is available on the CI nodes which fail, the latter is not.

Edit: I didn't see you added new commits, but its caused by the same problem: you are checking for one specific error message, but another one shows up (because of the API version).

@felixfontein
Copy link
Collaborator

BTW, you also need to mention the two new return values in the swarm_service return value example.

plugins/modules/docker_swarm_service.py Outdated Show resolved Hide resolved
plugins/modules/docker_swarm_service.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would be glad if someone more familiar with this module could also take a look at this :)

If nobody does, I'll also merge this one in roughly a week (probably next Saturday).

@WojciechowskiPiotr
Copy link
Collaborator

lgtm

@felixfontein felixfontein merged commit 3ad4982 into ansible-collections:main Feb 12, 2022
@felixfontein
Copy link
Collaborator

@andrasmaroy also thanks for this contribution!
@WojciechowskiPiotr thanks again for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants