-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cap_add
and cap_drop
handling for docker_swarm_service
#294
Implement cap_add
and cap_drop
handling for docker_swarm_service
#294
Conversation
tests/integration/targets/docker_swarm_service/tasks/tests/options.yml
Outdated
Show resolved
Hide resolved
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
I'm a bit confused about these CI failures, the errors seem unrelated to me, am I just not seeing the full picture? |
The CI errors are caused by your changes, see my explanation here: #294 (comment) Capabilities for swarm services need both a new enough Docker SDK for Python version and a new enough API version. The former is available on the CI nodes which fail, the latter is not. Edit: I didn't see you added new commits, but its caused by the same problem: you are checking for one specific error message, but another one shows up (because of the API version). |
tests/integration/targets/docker_swarm_service/tasks/tests/options.yml
Outdated
Show resolved
Hide resolved
BTW, you also need to mention the two new return values in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would be glad if someone more familiar with this module could also take a look at this :)
If nobody does, I'll also merge this one in roughly a week (probably next Saturday).
lgtm |
@andrasmaroy also thanks for this contribution! |
SUMMARY
With the 5.0.3 release of Docker SDK for Python support was added for these parameters for swarm services. With that adding support in Ansible should be as simple as exposing these variables for the module. That's what's done in this change.
ISSUE TYPE
COMPONENT NAME
docker_swarm_service