Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_compose: fix #12 #119

Merged
merged 5 commits into from
May 4, 2021
Merged

docker_compose: fix #12 #119

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c01e67a
fix #12
tonal Apr 6, 2021
475a7d1
Create 12-correct_pull_wo_starting.yaml
tonal Apr 13, 2021
95e89d2
Update changelogs/fragments/12-correct_pull_wo_starting.yaml
tonal Apr 13, 2021
de5a130
Update changelogs/fragments/12-correct_pull_wo_starting.yaml
tonal Apr 18, 2021
9c0c2b9
Update docker_compose.py
tonal Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/12-correct_pull_wo_starting.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "docker-compose - fix not pulling when ``state: present`` and ``stopped: true`` (https://github.com/ansible-collections/community.docker/issues/12, https://github.com/ansible-collections/community.docker/pull/119)."
5 changes: 3 additions & 2 deletions plugins/modules/docker_compose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ def cmd_up(self):
))
result['actions'].append(result_action)

if not self.check_mode and result['changed'] and not self.stopped:
if not self.check_mode and result['changed']:
out_redir_name, err_redir_name = make_redirection_tempfiles()
try:
with stdout_redirector(out_redir_name):
Expand All @@ -784,7 +784,8 @@ def cmd_up(self):
do_build=do_build,
detached=detached,
remove_orphans=self.remove_orphans,
timeout=self.timeout)
timeout=self.timeout,
start=not self.stopped)
except Exception as exc:
fail_reason = get_failure_info(exc, out_redir_name, err_redir_name,
msg_format="Error starting project %s")
Expand Down