Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_ssh_client flag #114

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Resolves #108.

This has no tests since we currently don't have a good way to test this. I will think more about this tomorrow.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

most modules and plugins

@felixfontein felixfontein changed the title [WIP] Add use_ssh_client flag Add use_ssh_client flag Mar 27, 2021
@felixfontein felixfontein changed the title Add use_ssh_client flag [WIP] Add use_ssh_client flag Mar 27, 2021
@felixfontein felixfontein force-pushed the use_ssh_client branch 2 times, most recently from 96fb43d to 85b9c34 Compare March 27, 2021 14:02
@felixfontein felixfontein changed the title [WIP] Add use_ssh_client flag Add use_ssh_client flag Mar 27, 2021
@felixfontein
Copy link
Collaborator Author

ready_for_review

@MisterWS
Copy link

MisterWS commented Apr 1, 2021

As mentioned in #108, LGTM from my limited testing.

@felixfontein felixfontein merged commit e9b10ee into ansible-collections:main Apr 2, 2021
@felixfontein felixfontein deleted the use_ssh_client branch April 2, 2021 08:14
@felixfontein
Copy link
Collaborator Author

@MisterWS thanks a lot for testing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: support "use_ssh_client" parameter for Docker SSH connections
2 participants