Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust deprecations #1

Merged
merged 8 commits into from
Oct 30, 2020

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

community.general 2.0.0 -> remove now
community.general 3.0.0 -> community.docker 2.0.0

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request

@felixfontein
Copy link
Collaborator Author

Restart tests.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@465dc91). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   73.44%           
=======================================
  Files           ?       37           
  Lines           ?     6270           
  Branches        ?     1419           
=======================================
  Hits            ?     4605           
  Misses          ?     1311           
  Partials        ?      354           
Flag Coverage Δ
#integration 73.67% <0.00%> (?)
#python_2_6 22.82% <0.00%> (?)
#python_2_7 73.41% <0.00%> (?)
#python_3_5 23.01% <0.00%> (?)
#python_3_6 73.25% <0.00%> (?)
#python_3_7 67.91% <0.00%> (?)
#python_3_8 53.29% <0.00%> (?)
#python_3_9 22.96% <0.00%> (?)
#sanity 15.34% <0.00%> (?)
#units 23.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465dc91...1c4f4ab. Read the comment docs.

@felixfontein
Copy link
Collaborator Author

@WojciechowskiPiotr if you have some time, would be great if you could take a look at this PR (or at least some parts of it). There are quite a lot of things that were scheduled for removal, I hope I didn't screw anything (or too much ;) ) up...

@felixfontein
Copy link
Collaborator Author

I went through to all changes another time, and found a few things to change / fix. I would be really glad if someone else could also go through it!

@felixfontein
Copy link
Collaborator Author

If nobody complains, I'll merge tomorrow. If something is wrong, we can still fix it after 0.1.0 is released.

@felixfontein
Copy link
Collaborator Author

Went through everything once more.

@felixfontein felixfontein merged commit 01e47a6 into ansible-collections:main Oct 30, 2020
@felixfontein felixfontein deleted the deprecations branch October 30, 2020 05:48
felixfontein added a commit that referenced this pull request Oct 30, 2020
* First batch of c.g 2.0.0 deprecations.

* Remove use_tls and force from docker_image.

* More removals.

* Change community.general 3.0.0 deprecations to community.docker 2.0.0.

* Fix sanity.

* Fixing some bugs.

* Add PR URL to fragment.

ci_complete
ci_coverage

* Improve docs, remove superfluous code.
slicen added a commit to slicen/ansible-role-portainer that referenced this pull request Mar 12, 2021
hagzag pushed a commit to shelleg/ansible-role-portainer that referenced this pull request Mar 12, 2021
Hebo pushed a commit to Hebo/ansible-role-portainer that referenced this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant