From a3313a73946e35e89a7f9aabe8586cbe81906761 Mon Sep 17 00:00:00 2001 From: Dmytro Vorotyntsev <2937451+vorotech@users.noreply.github.com> Date: Mon, 15 Feb 2021 10:35:32 +0200 Subject: [PATCH 1/2] dict Tags to list on restore_db_instance_from_db_snapshot Also, map Tags parameters from the dict to list during `restore_db_instance_from_db_snapshot` method additionally to existing `create_db_instance` and `create_db_instance_read_replica` --- plugins/modules/rds_instance.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/modules/rds_instance.py b/plugins/modules/rds_instance.py index 0dd763c369f..8f3a7a39ae1 100644 --- a/plugins/modules/rds_instance.py +++ b/plugins/modules/rds_instance.py @@ -844,7 +844,7 @@ def get_parameters(client, module, parameters, method_name): if parameters.get('ProcessorFeatures') == [] and not method_name == 'modify_db_instance': parameters.pop('ProcessorFeatures') - if method_name == 'create_db_instance' or method_name == 'create_db_instance_read_replica': + if method_name in ['create_db_instance', 'create_db_instance_read_replica', 'restore_db_instance_from_db_snapshot']: if parameters.get('Tags'): parameters['Tags'] = ansible_dict_to_boto3_tag_list(parameters['Tags']) From 1828213237ce9b0d98cfbed7bf5a2fb83ce31e4b Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Mon, 12 Apr 2021 09:37:11 +0200 Subject: [PATCH 2/2] changelog --- .../414-rds_instance-tags-on-creation-from-snapshot.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/414-rds_instance-tags-on-creation-from-snapshot.yml diff --git a/changelogs/fragments/414-rds_instance-tags-on-creation-from-snapshot.yml b/changelogs/fragments/414-rds_instance-tags-on-creation-from-snapshot.yml new file mode 100644 index 00000000000..bac87b428c6 --- /dev/null +++ b/changelogs/fragments/414-rds_instance-tags-on-creation-from-snapshot.yml @@ -0,0 +1,2 @@ +bugfixes: +- rds_instance - fixes bug preventing the use of tags when creating an RDS instance from a snapshot (https://github.com/ansible-collections/community.aws/issues/530).