From 9ca55407384506da9bf3018e1a8e24ae256d5cd5 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Thu, 2 Jun 2022 11:11:15 +0200 Subject: [PATCH] Tagging fragment - Move simplest cases over to the docs fragment. (#1200) Tagging fragment - rds_instance_snapshot - Move over to the docs fragment. SUMMARY The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off. ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance_snapshot ADDITIONAL INFORMATION The change itself was approved on #1182 --- changelogs/fragments/1200-tagging.yml | 2 ++ plugins/modules/rds_instance_snapshot.py | 27 ++++++++---------------- 2 files changed, 11 insertions(+), 18 deletions(-) create mode 100644 changelogs/fragments/1200-tagging.yml diff --git a/changelogs/fragments/1200-tagging.yml b/changelogs/fragments/1200-tagging.yml new file mode 100644 index 00000000000..e38cca12d96 --- /dev/null +++ b/changelogs/fragments/1200-tagging.yml @@ -0,0 +1,2 @@ +minor_changes: +- rds_instance_snapshot - ``resource_tags`` has been added as an alias for the ``tags`` parameter (https://github.com/ansible-collections/community.aws/pull/1200). diff --git a/plugins/modules/rds_instance_snapshot.py b/plugins/modules/rds_instance_snapshot.py index 0d7a50a06e7..fc32ef75e4c 100644 --- a/plugins/modules/rds_instance_snapshot.py +++ b/plugins/modules/rds_instance_snapshot.py @@ -14,7 +14,7 @@ version_added: 1.0.0 short_description: Manage Amazon RDS instance snapshots description: - - Creates or deletes RDS snapshots. + - Creates or deletes RDS snapshots. options: state: description: @@ -68,24 +68,15 @@ - how long before wait gives up, in seconds. default: 300 type: int - tags: - description: - - tags dict to apply to a snapshot. - type: dict - purge_tags: - description: - - whether to remove tags not present in the I(tags) parameter. - default: True - type: bool author: - - "Will Thames (@willthames)" - - "Michael De La Rue (@mikedlr)" - - "Alina Buzachis (@alinabuzachis)" - - "Joseph Torcasso (@jatorcasso)" + - "Will Thames (@willthames)" + - "Michael De La Rue (@mikedlr)" + - "Alina Buzachis (@alinabuzachis)" + - "Joseph Torcasso (@jatorcasso)" extends_documentation_fragment: -- amazon.aws.aws -- amazon.aws.ec2 - + - amazon.aws.aws + - amazon.aws.ec2 + - amazon.aws.tags ''' EXAMPLES = r''' @@ -359,7 +350,7 @@ def main(): source_db_snapshot_identifier=dict(aliases=['source_id', 'source_snapshot_id']), wait=dict(type='bool', default=False), wait_timeout=dict(type='int', default=300), - tags=dict(type='dict'), + tags=dict(type='dict', aliases=['resource_tags']), purge_tags=dict(type='bool', default=True), copy_tags=dict(type='bool', default=False), source_region=dict(type='str'),