From 9b990b93787a5ee48161e5f9c9c38910ba5038be Mon Sep 17 00:00:00 2001 From: Alina Buzachis Date: Thu, 24 Mar 2022 18:30:15 +0100 Subject: [PATCH] Add a fake integration suite including an aliases file listing every module name with missing integration tests. (#986) (#1010) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add a fake integration suite including an aliases file listing every … …module name with missing integration tests. (#986) Prevent CI to be run for whole collection when modules without integration tests are modified Add a fake integration suite including an aliases file listing every module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). Add some of the modules in the aliases files where it makes more sense. SUMMARY ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Woolley --- .../targets/aws_waf_web_acl/aliases | 2 + tests/integration/targets/ec2_asg/aliases | 2 + tests/integration/targets/ecs_cluster/aliases | 1 + .../integration/targets/elb_instance/aliases | 2 + .../targets/legacy_missing_tests/README.md | 5 +++ .../targets/legacy_missing_tests/aliases | 41 +++++++++++++++++++ 6 files changed, 53 insertions(+) create mode 100644 tests/integration/targets/legacy_missing_tests/README.md create mode 100644 tests/integration/targets/legacy_missing_tests/aliases diff --git a/tests/integration/targets/aws_waf_web_acl/aliases b/tests/integration/targets/aws_waf_web_acl/aliases index bbae3d77135..5692e3fb007 100644 --- a/tests/integration/targets/aws_waf_web_acl/aliases +++ b/tests/integration/targets/aws_waf_web_acl/aliases @@ -8,3 +8,5 @@ aws_waf_info aws_waf_web_acl aws_waf_web_match aws_waf_web_rule +aws_waf_condition +aws_waf_rule \ No newline at end of file diff --git a/tests/integration/targets/ec2_asg/aliases b/tests/integration/targets/ec2_asg/aliases index a1db4545242..cf3b923d5c4 100644 --- a/tests/integration/targets/ec2_asg/aliases +++ b/tests/integration/targets/ec2_asg/aliases @@ -4,3 +4,5 @@ disabled cloud/aws + +ec2_asg_info diff --git a/tests/integration/targets/ecs_cluster/aliases b/tests/integration/targets/ecs_cluster/aliases index f120eea7d6f..8f38aa6e6ec 100644 --- a/tests/integration/targets/ecs_cluster/aliases +++ b/tests/integration/targets/ecs_cluster/aliases @@ -4,6 +4,7 @@ unsupported cloud/aws +ecs_service ecs_service_info ecs_task ecs_taskdefinition diff --git a/tests/integration/targets/elb_instance/aliases b/tests/integration/targets/elb_instance/aliases index 4ef4b2067d0..913fefaa9ab 100644 --- a/tests/integration/targets/elb_instance/aliases +++ b/tests/integration/targets/elb_instance/aliases @@ -1 +1,3 @@ cloud/aws + +elb_classic_lb_info diff --git a/tests/integration/targets/legacy_missing_tests/README.md b/tests/integration/targets/legacy_missing_tests/README.md new file mode 100644 index 00000000000..f13928252aa --- /dev/null +++ b/tests/integration/targets/legacy_missing_tests/README.md @@ -0,0 +1,5 @@ +## Fake integration suite + +This is a fake integration suite including an aliases file listing every module name with missing integration tests. + +This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). \ No newline at end of file diff --git a/tests/integration/targets/legacy_missing_tests/aliases b/tests/integration/targets/legacy_missing_tests/aliases new file mode 100644 index 00000000000..a97fc0a349a --- /dev/null +++ b/tests/integration/targets/legacy_missing_tests/aliases @@ -0,0 +1,41 @@ +disabled + +# Modules that do not have test suites +aws_application_scaling_policy +aws_batch_compute_environment +aws_batch_job_definition +aws_batch_job_queue +aws_direct_connect_confirm_connection +aws_direct_connect_connection +aws_direct_connect_gateway +aws_direct_connect_link_aggregation_group +aws_direct_connect_virtual_interface +aws_s3_cors +aws_sgw_info +cloudfront_info +cloudfront_invalidation +cloudfront_origin_access_identity +cloudwatchevent_rule +cloudwatchlogs_log_group_info +data_pipeline +dynamodb_ttl +ec2_ami_copy +ec2_asg_lifecycle_hook +ec2_customer_gateway +ec2_customer_gateway_info +ec2_snapshot_copy +ec2_vpc_vgw_info +ec2_win_password +ecs_attribute +elasticache_info +elasticache_parameter_group +elasticache_snapshot +elb_target_group_info +iam_mfa_device_info +lambda_event +rds_instance_snapshot +rds_snapshot_info +redshift_cross_region_snapshots +s3_website +sts_session_token +ec2_vpc_vpn