diff --git a/changelogs/fragments/1078-rds_instance_snapshot-add-copy-snapshot.yml b/changelogs/fragments/1078-rds_instance_snapshot-add-copy-snapshot.yml new file mode 100644 index 00000000000..dae38806313 --- /dev/null +++ b/changelogs/fragments/1078-rds_instance_snapshot-add-copy-snapshot.yml @@ -0,0 +1,5 @@ +minor_changes: + - rds_instance_snapshot - add copy_db_snapshot functionality (https://github.com/ansible-collections/community.aws/pull/1078). + +bugfixes: + - don't require `db_instance_identifier` on state = present (https://github.com/ansible-collections/community.aws/pull/1078). diff --git a/changelogs/fragments/1078-rds_instance_snapshot-add-integration-tests-check-mode-copy-snapshot.yml b/changelogs/fragments/1078-rds_instance_snapshot-add-integration-tests-check-mode-copy-snapshot.yml deleted file mode 100644 index b74ce6b83ce..00000000000 --- a/changelogs/fragments/1078-rds_instance_snapshot-add-integration-tests-check-mode-copy-snapshot.yml +++ /dev/null @@ -1,6 +0,0 @@ -minor_changes: - - rds_instance_snapshot - add check mode support, integration tests, and copy_db_snapshot functionality (https://github.com/ansible-collections/community.aws/pull/1078). - -bugfixes: - - return 'tags' in response data - previously returned 'tag_list' from RDS client (https://github.com/ansible-collections/community.aws/pull/1078). - - don't require `db_instance_identifier` on state = present (https://github.com/ansible-collections/community.aws/pull/1078). diff --git a/plugins/modules/rds_instance_snapshot.py b/plugins/modules/rds_instance_snapshot.py index e523a13d632..974274e41bb 100644 --- a/plugins/modules/rds_instance_snapshot.py +++ b/plugins/modules/rds_instance_snapshot.py @@ -385,4 +385,4 @@ def main(): if __name__ == '__main__': - main() \ No newline at end of file + main() diff --git a/tests/integration/targets/rds_instance_snapshot/tasks/main.yml b/tests/integration/targets/rds_instance_snapshot/tasks/main.yml index 0d70f65df51..e07f8169f3a 100644 --- a/tests/integration/targets/rds_instance_snapshot/tasks/main.yml +++ b/tests/integration/targets/rds_instance_snapshot/tasks/main.yml @@ -498,10 +498,8 @@ - name: Delete the existing RDS instance without creating a final snapshot rds_instance: state: absent - instance_id: "{{ item }}" + instance_id: "{{ instance_id }}" skip_final_snapshot: True wait: false register: _result_delete_instance ignore_errors: true - loop: - - "{{ instance_id }}"