Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vrf_address_family module #489

Merged
merged 44 commits into from
Jul 26, 2024
Merged

Add vrf_address_family module #489

merged 44 commits into from
Jul 26, 2024

Conversation

Ruchip16
Copy link
Contributor

@Ruchip16 Ruchip16 commented May 13, 2024 •
edited
Loading

SUMMARY

This PR adds support for iosxr_vrf_address_family resource module

DESCRIPTION

Here is the model design for the iosxr_vrf_address_family resource module

ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

cisco.iosxr.iosxr_vrf_address_family

MILESTONES
  • Parsing entire argspec ( which covers gathered and parsed state )
  • Merged and Deleted state working
  • Replaced state working
  • Overridden state working
  • Unit tests & Integration tests

Fixes: #462

Ruchip16 and others added 21 commits January 24, 2024 18:07
@Ruchip16
Add vrf module [WIP]
c94fbb9
@Ruchip16
adds parsed state & gathered state
3f15ecd
@Ruchip16
minor changes in config
a053529
@Ruchip16
working state - parsed & merged
ca39096
@Ruchip16
states implementation
54111bc
@Ruchip16
change name vrf -> vrfs throughout
59a846c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2ab3671 
for more information, see https://pre-commit.ci
@Ruchip16
Merge branch 'main' into feature-vrf
07161a5
@Ruchip16
changes
01de125
@Ruchip16
push changes
b590dd9
@Ruchip16
unit tests running :D
c8da71f
@Ruchip16
successful integration tests & unit tests
7e575c5
@Ruchip16
Merge branch 'main' of https://github.com/ansible-collections/cisco.i…
3354229 
…osxr into feature-vrf
@Ruchip16
changes
807b4ab
@Ruchip16
changes
8efe0e8
@Ruchip16
changes
3b319e9
@Ruchip16
sanity test fix
b2124c3
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
04be084 
for more information, see https://pre-commit.ci
@Ruchip16
review changes
573f87e
@Ruchip16
Merge branch 'feature-vrf' of https://github.com/ansible-collections/…
03bf25a 
…cisco.iosxr into feature-vrf
@Ruchip16
WIP vrf_address_family module
16c08a2
@Ruchip16 Ruchip16 added feature This issue/PR relates to a feature request. vrf_address_family vrf_address_family resource module labels May 13, 2024
rohitthakur2590
rohitthakur2590 requested changes Jul 4, 2024
View reviewed changes
README.md Show resolved Hide resolved
KB-perByte
KB-perByte requested changes Jul 24, 2024
View reviewed changes
changelogs/fragments/add_vrfs_module.yaml Outdated Show resolved Hide resolved
plugins/modules/iosxr_vrf_address_family.py Outdated Show resolved Hide resolved
plugins/modules/iosxr_vrf_address_family.py Outdated Show resolved Hide resolved
@Ruchip16 Ruchip16 requested a review from KB-perByte July 26, 2024 12:14
@Ruchip16 Ruchip16 merged commit a7ecb28 into main Jul 26, 2024
48 checks passed
@Ruchip16 Ruchip16 mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitthakur2590 rohitthakur2590 rohitthakur2590 approved these changes

@KB-perByte KB-perByte KB-perByte approved these changes

@roverflow roverflow Awaiting requested review from roverflow

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. vrf_address_family vrf_address_family resource module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for vrf module as nxos or ios collection
4 participants
@Ruchip16 @KB-perByte @rohitthakur2590 @roverflow