add support for multiple local-preference #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AAYUSH2091 can you please add changelog |
AAYUSH2091
force-pushed
the
feature/add-local-preference-support
branch
from
e1d82a1
to
29bd8ed
Compare
AAYUSH2091
force-pushed
the
feature/add-local-preference-support
branch
from
d6c92ec
to
22b8424
Compare
KB-perByte
reviewed
Nov 4, 2024
|
@KB-perByte please review this once I have also added the integration tests as well to support multiple local-preference values. |
KB-perByte
requested changes
Nov 6, 2024
plugins/module_utils/network/iosxr/config/route_maps/route_maps.py
Outdated
Show resolved
Hide resolved
…umber to metric_number
Co-authored-by: Sagar Paul <[email protected]>
AAYUSH2091
force-pushed
the
feature/add-local-preference-support
branch
from
5e9bae0
to
ad56785
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 76.91% 78.52% +1.60%
==========================================
Files 166 182 +16
Lines 11298 11953 +655
==========================================
+ Hits 8690 9386 +696
+ Misses 2608 2567 -41 |
AAYUSH2091
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds support for single local-preference values in route maps with special characters (*,+,-).
Fixes the issue with local-preference values not being captured correctly in route-maps.
Fixes #516
ISSUE TYPE
COMPONENT NAME
iosxr_route_maps