Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of "Object Ownership" on S3 buckets #245

Closed
rpt-ahowe opened this issue Jan 18, 2021 · 6 comments
Closed

Allow configuration of "Object Ownership" on S3 buckets #245

rpt-ahowe opened this issue Jan 18, 2021 · 6 comments
Assignees
Labels
easyfix Good for new comers and easy to start with contribution feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@rpt-ahowe
Copy link

SUMMARY

I would like to be able to set the "Object Ownership" setting on my buckets managed by ansible.
This allows me to retain control of objects uploaded to my bucket from other accounts.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

This feature would allow the bucket settting "Object Ownership" to be changed from the default of "Object writer" to "Bucket owner preferred". In conjunction with a bucket policy condition, this allows a bucket owner to ensure that all objects uploaded to a bucket are always owned by them.

This option is documented here: https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html and https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.put_bucket_ownership_controls

# Create a bucket, add a policy from a file, and set the Object Ownership to Bucket owner preferred
- amazon.aws.s3_bucket:
    name: mys3bucket
    policy: "{{ lookup('file','policy.json') }}"
    object_ownership: bucket_owner_preferred
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Jan 18, 2021
@goneri
Copy link
Member

goneri commented Jan 20, 2021

Hi @rpt-ahowe,

Thank you for the suggestion. It looks like it's a rather simple change. Is this something you want to implement yourself?

@goneri goneri added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels Jan 20, 2021
@abikouo abikouo added the easyfix Good for new comers and easy to start with contribution label Mar 24, 2021
@abikouo abikouo self-assigned this Mar 24, 2021
@abikouo abikouo removed the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Mar 26, 2021
@ansibullbot ansibullbot added the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Mar 26, 2021
@abikouo abikouo removed the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Mar 26, 2021
@ansibullbot ansibullbot added the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Mar 26, 2021
@abikouo abikouo removed the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Mar 29, 2021
@ansibullbot ansibullbot added the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Mar 29, 2021
@tremble tremble removed the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Apr 29, 2021
@ansibullbot ansibullbot added the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Apr 29, 2021
@abikouo
Copy link
Contributor

abikouo commented May 5, 2021

@rpt-ahowe PR has been merged. Thanks again for your suggestion.

@abikouo abikouo closed this as completed May 5, 2021
@tremble
Copy link
Contributor

tremble commented May 5, 2021

#311 - the feature will be available with version 2.0.0 of this collection (expected by the end of the month)

@rpt-ahowe
Copy link
Author

Hi all, Any update on when version 2.0.0 will be release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easyfix Good for new comers and easy to start with contribution feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Development

No branches or pull requests

5 participants