From a0d085a4e4e1e52f6835ece1826b8b7fcbd15b55 Mon Sep 17 00:00:00 2001 From: GomathiselviS Date: Fri, 20 Oct 2023 12:26:26 -0400 Subject: [PATCH 1/2] Divide github workflows for consistency --- .github/workflows/all_green_check.yml | 9 ++++++--- .github/workflows/changelog.yml | 8 ++++++++ .../workflows/{changelog_and_linters.yml => linters.yml} | 2 -- 3 files changed, 14 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/changelog.yml rename .github/workflows/{changelog_and_linters.yml => linters.yml} (73%) diff --git a/.github/workflows/all_green_check.yml b/.github/workflows/all_green_check.yml index 5ea5cc71220..dd54f959cd2 100644 --- a/.github/workflows/all_green_check.yml +++ b/.github/workflows/all_green_check.yml @@ -20,8 +20,10 @@ on: # yamllint disable-line rule:truthy - '*' jobs: - changelog-and-linters: - uses: ./.github/workflows/changelog_and_linters.yml # use the callable changelog-and-linters job to run tests + changelog: + uses: ./.github/workflows/changelog.yml # use the callable changelog job to run tests + linters: + uses: ./.github/workflows/linters.yml # use the callable linters job to run tests sanity: uses: ./.github/workflows/sanity.yml # use the callable sanity job to run tests units: @@ -29,7 +31,8 @@ jobs: all_green: if: ${{ always() }} needs: - - changelog-and-linters + - changelog + - linters - sanity - units runs-on: ubuntu-latest diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml new file mode 100644 index 00000000000..5a779b72e15 --- /dev/null +++ b/.github/workflows/changelog.yml @@ -0,0 +1,8 @@ +--- +name: changelog and linters + +on: [workflow_call] # allow this workflow to be called from other workflows + +jobs: + changelog: + uses: ansible-network/github_actions/.github/workflows/changelog.yml@main diff --git a/.github/workflows/changelog_and_linters.yml b/.github/workflows/linters.yml similarity index 73% rename from .github/workflows/changelog_and_linters.yml rename to .github/workflows/linters.yml index 4029505d03f..bc737d2a1f8 100644 --- a/.github/workflows/changelog_and_linters.yml +++ b/.github/workflows/linters.yml @@ -4,8 +4,6 @@ name: changelog and linters on: [workflow_call] # allow this workflow to be called from other workflows jobs: - changelog: - uses: ansible-network/github_actions/.github/workflows/changelog.yml@main linters: uses: ansible-network/github_actions/.github/workflows/tox.yml@main with: From 3942ddde2d7d3230fdd964fcab05cc33b73215b2 Mon Sep 17 00:00:00 2001 From: GomathiselviS Date: Fri, 20 Oct 2023 12:28:26 -0400 Subject: [PATCH 2/2] fixed all_green --- .github/workflows/all_green_check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/all_green_check.yml b/.github/workflows/all_green_check.yml index dd54f959cd2..9d6ed407964 100644 --- a/.github/workflows/all_green_check.yml +++ b/.github/workflows/all_green_check.yml @@ -39,7 +39,8 @@ jobs: steps: - run: >- python -c "assert set([ - '${{ needs.changelog-and-linters.result }}', + '${{ needs.changelog.result }}', + '${{ needs.linters.result }}', '${{ needs.sanity.result }}', '${{ needs.units.result }}' ]) == {'success'}"