Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http 0.2 to http 1 #50

Closed
neckaros opened this issue Mar 13, 2024 · 3 comments · Fixed by #51
Closed

Upgrade http 0.2 to http 1 #50

neckaros opened this issue Mar 13, 2024 · 3 comments · Fixed by #51

Comments

@neckaros
Copy link

Would it be possible to use a more recent version of http? from 0.2 to latest 1.1.0?

Right now we get an error with this crate if using a more recent version in our dependencies:

http::request::Request<Vec> = req.try_into_http_request(ctx).unwrap...
| ------------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected Request<Vec<...>>, found Request<_>

note: Request<_> and Request<Vec<...>> have similar names, but are actually distinct types

@ansg191
Copy link
Owner

ansg191 commented Mar 14, 2024

Yes. I've been meaning to upgrade for a while now. I've just been waiting on reqwest (which I use for tests) to upgrade.

They recently merged the upgrade into master, but it is blocked on some other breaking changes.

I'm gonna upgrade it anyway and temporarily change the testing client to ureq until 0.12 is released. I'm tired of checking reqwest's status everyday.

This will be upgraded in #51, and a new release will be created after it is merged.

@neckaros
Copy link
Author

Thank you! I indeed noticed that Reqwest still use 0.2

@neckaros
Copy link
Author

For information:
On Reqwest side dev has been temp reverted here:
seanmonstar/reqwest#2170

it's available on 0.12-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants