Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test compilation of all STLC forms to VampIR #59

Open
rokopt opened this issue Feb 13, 2023 · 3 comments
Open

Test compilation of all STLC forms to VampIR #59

rokopt opened this issue Feb 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request testing Bugs in or enhancements to tests

Comments

@rokopt
Copy link
Member

rokopt commented Feb 13, 2023

Not all STLC forms yet have tests for compilation all the way to VampIR. I should add tests for all of them. This will depend on implementing at least

I will also need to work out the status of

@rokopt
Copy link
Member Author

rokopt commented May 9, 2023

Can this be closed as fixed by the latest STLC fixes/enhancements such as #115 and #120 ?

@mariari
Copy link
Member

mariari commented May 9, 2023

no, see

https://anoma.github.io/geb/tests/cover-index.html

Namely https://anoma.github.io/geb/tests/436c3f34b05ce242465dc22105ccf7a3.html

shows that we don't have any tests that touch the snd logic.

we need higher test coverage and interpreter examples in general. I posted some recently but more should be had

@rokopt rokopt added enhancement New feature or request testing Bugs in or enhancements to tests labels May 9, 2023
@rokopt
Copy link
Member Author

rokopt commented May 10, 2023

shows that we don't have any tests that touch the snd logic.

We should test at least this (snd), some projections, and some ill-typed cases. See the automated code coverage output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Bugs in or enhancements to tests
Projects
None yet
Development

No branches or pull requests

2 participants