-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI / CD system to this repository #377
Comments
Just to mention: manual reviewing changes shouldn't be a provlem now. All you have to do is:
|
As this action requiers user GitHub API token, I think the only possible solution for testing would be be: |
We'd better add a kind of dry-run option that will be able to run without user password. |
It would be also great if you could take a look at #375 as it appears to solve many issues and so it would be gread to merge it ASAP as well. |
@aravindvnair99 @pseusys We can introduce a new env variable flag for testing which will run the action with all options enabled and when our module is about to write readme on actual github repo with the env flag enabled the module will just print the output on console. Feel free to ask question |
Yeah, I like the first solution. In addition we can make the output more verbose for this dry run. |
@anmol098 so, we'll need a sample GitHub read token together with WakaTime read token in repository secrets. |
Ok perfect I'll add these 2 tokens to repository secret 👍 |
@anmol098 great, keep me informed! |
with last issue #398 for file not found exception. we need to make changes to the workflow how we test the action. new approach could be build and publish the docker image with the tag as PR number then pull the docker image in that docker image run action with all flags enabled and pass the output as a comment. |
Or better do both and compare the results because we shouldn't forget about local running possibility. |
I would also suggest publishing the Docker image for every pull request (named after the pull request, of course) for us and users to be able to test the action not on main branch only. |
Considering we got #423 as well. We need to prioritise this. I agree with doing both, but primary should be GitHub action as that's what most people are using. I haven't come across a local user yet although we might have a few. |
I would suggest the following solution:
Unfortunately, I won't be able to deal with it soon. |
Objectives:
The text was updated successfully, but these errors were encountered: