-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Note Editor Toolbar custom button rename / reposition #9077
Comments
don't you think reducing other's width of buttons will reduce their accessibility, and I personally think in this case custom button's (1,2) width is less as compare to others, so a nice solution would be to increase their width to make it easier to use.
do you want to change button's position?
it would be great if you create new feature request issue for this |
Yes. For me this is the most desired need, because I hardly use the current default buttons. I have to swipe that bar to the far right every time to use the custom button
I'll tell you clearly, I never pressed the wrong button in the previous version (the width of the previous button is narrower than now). Of course, exactly how wide to set this is really a technical issue. But I think it should be narrower than it is now. |
In order to reduce padding we would need to know for certain that it does not violate accessibility - that's something we are paying attention to now and anecdotal statements like "I don't mind if it's narrower" are not valid in this context. We have users with essential tremor for instance and your statement will not provide them comfort |
You're right. When you decide exactly how wide to use, could you please let me first be able to change the ordering of the button? This is really very important to me. Also, the renaming feature can be done together? Please. :) |
The problem I have with further development of this specific feature is that the "note editor toolbar" in general is a temporary solution on the way to #1377 ("what you see is what you get" editor). I'm not interested in seeing further feature development here as the Note Editor Toolbar as an entire feature should go away. However, taking this as a sort of sub-feature request for the WYSIWYG editor ("there should be macro buttons", "macro buttons should be nameable vs just numbered", "WYSIWYG button order may be configurable" is reasonable) though not as important as simply getting WYSIWYG editing done. If we took these as feature requests there I think keeping the WYSIWYG button order stable in general is a good idea but if there are custom macros maybe they may be added as a second row or something, since the AppBar buttons as a similar feature is not something people use a lot and I imagine this will be similar - it's a niche use case so having it as a maintenance burden mixed up with the main the main set of editing buttons is not something I want to see |
@mikehardy Showing a button that can't be displayed on one line as two lines is really better than letting the user customize the position, IMHO. Also, it's really important to allow renaming. |
These things are all exactly as important as your motivation to implement them, don't forget... |
I have used single ascii character for showing addons button icon in note editor js addons. |
Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically |
Is your feature request related to a problem? Please describe.
As the image, I'm in version 2.15.4. There is a long bar in that toolbar now, and my custom button will be at the end of the toolbar, which caused me to have to scroll it every time I use it.
Describe the solution you'd like
The text was updated successfully, but these errors were encountered: