Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Notifications. (android issue???) #8114

Closed
boydkelly opened this issue Feb 15, 2021 · 54 comments
Closed

[Bug] Notifications. (android issue???) #8114

boydkelly opened this issue Feb 15, 2021 · 54 comments

Comments

@boydkelly
Copy link

boydkelly commented Feb 15, 2021

When I have notifications enabled, i get notified over and over and over and over and over and over and over and over...

If not 5 seconds then 5 min after I dismiss.

Is this an android problem? I wouldn't mind getting a notification once (or heck twice) a day. But 5 seconds after I dismiss the anki notification it comes back. Why is this happeing?

@mikehardy
Copy link
Member

Mostly because our notifications sub-system needs a lot of work, and it hasn't been a priority. I feel your pain but also just swipe away the notifications as I haven't had time personally to implement a fix 🤷

@david-allison
Copy link
Member

david-allison commented Feb 18, 2021

It's to do with the widget, Best to disable the notifications in the app/OS settings. Mirroring mike, we need someone who cares about the notifications to spend a few days fixing them, but it hasn't hit my priority yet as I don't use them.

@moqi-Git
Copy link
Contributor

I want to try fixing this but I can't reproduce on my device. Which kind of notification bothered you?

@boydkelly
Copy link
Author

Hi,
I was probably in a grumpy mood the morning I posted that, as this is nothing seriously affecting Anki. But I have under settings general notifications. Notify when more than 75 cards due. Probably because I have 4 decks and several filtered decks, I get 3 or 4 notifications when I look at my phone in the morning. But the issue is if I dismiss the notifications, because I just can't study, they will come back again, sometimes within seconds, and I have to keep dismissing them. Hey I was actually finding that kind of funny at first that Anki was so 'determined' to get me on the right track! But then after a while with constant notifications all day it becomes wearysome. So they are off now. No biggie. If you can make notifications come on only once in a 24 hr period that would be better IMO.

@mikehardy
Copy link
Member

I reproduce the same behavior, and think I even wrote the code that did it! Because, awesome 😅 - hey, more notifications is better than 0? But in this case only slightly

@2tanayk
Copy link
Contributor

2tanayk commented Mar 17, 2021

Mostly because our notifications sub-system needs a lot of work, and it hasn't been a priority. I feel your pain but also just swipe away the notifications as I haven't had time personally to implement a fix 🤷

will do the work on the notifications thing, let me reproduce the issue and I will get started then 👍

@2tanayk
Copy link
Contributor

2tanayk commented Mar 17, 2021

Thanks for assigning me this issue @david-allison-1 sir!
It would really be great if you provide me with a bit of guidance for this issue as I do not know much about the notifications sub-system (although I will search and start studying the code as soon as possible).
Just brief me about any key aspects of how it works right now, Thanks in advance!

@mikehardy
Copy link
Member

#4944

@2tanayk
Copy link
Contributor

2tanayk commented Mar 18, 2021

@mikehardy sir first of all thanks for linking that discussion to me,but that discussion is 2 years old and as someone who is new to this project (I might be asking too much) I would really like to get a gist of what exactly needs to be done, like in points, would really help.
That being said I've already started studying the code and using the existing resources to understand the current system in depth

@david-allison
Copy link
Member

david-allison commented Mar 19, 2021

https://developer.android.com/guide/topics/ui/notifiers/notifications

https://github.com/ankidroid/Anki-Android/blob/master/AnkiDroid/src/main/java/com/ichi2/anki/services/NotificationService.java

https://github.com/ankidroid/Anki-Android/blob/master/AnkiDroid/src/main/java/com/ichi2/anki/NotificationChannels.java

and related history.

Nothing's really changed in the last 2 years, just needs someone to form a plan, explain how we currently use notifications, and get it working.

Do note that notification channels are immutable from the program once created - you can't update values, only the user can with their notification settings.

This means things such as the vibrate pattern are effectively "write-once", as we can't change them, and Android doesn't provide an option for the user to change them

@Arthur-Milchior
Copy link
Member

Do you get one notification by deck or do you get the notification for the same deck everytime? Because one problem is that there are notifications for each top level deck potentially. I don't like it but was told to let it this way.
I can imagine that android limit notification to a small number and queue the next notification until the first one are seen.

@mikehardy
Copy link
Member

Android I think has a limit of 50 notifications at once, and some phones (Samsung I think?) limit to 500 pending intents (think "alarms") set at once.

I think the first thing to solve is that if notifications are swiped away for the day, they actually stay away until the next day

@2tanayk
Copy link
Contributor

2tanayk commented Mar 20, 2021

Working on this

@haran2248
Copy link
Contributor

haran2248 commented Mar 23, 2021

Can I try taking up this issue as well?If it is ok with @2tanayk

@2tanayk
Copy link
Contributor

2tanayk commented Mar 23, 2021

Can I try taking up this issue as well?If it is ok with @2tanayk

I don't think two people should work at the same time

@prateek-singh-3212
Copy link
Member

Hi @2tanayk,
If you have any need, I would love to help you with this issue.

@2tanayk
Copy link
Contributor

2tanayk commented Apr 2, 2021

Hi @2tanayk,
If you have any need, I would love to help you with this issue.

Sure thanks!

@2tanayk
Copy link
Contributor

2tanayk commented Apr 2, 2021

I am working on it,was a bit busy(because of college 😬),will get it done soon :)

@david-allison
Copy link
Member

@2tanayk Life comes first, take your time, grades are important.

@2tanayk
Copy link
Contributor

2tanayk commented Apr 8, 2021

if some1 else wants they can take this issue as I have not been able to spend ample time at this ,really sorry for any inconvenience caused :(,but I'll definitely attend to it if nobody does

@david-allison
Copy link
Member

Don't worry! Life comes first. Give me a ping when you have time

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@eskoONE
Copy link

eskoONE commented Jul 6, 2021

Can I try taking up this issue as well?If it is ok with @2tanayk

Hi @2tanayk,
If you have any need, I would love to help you with this issue.

Do you guys want to have another look at this issue? The guy that wanted to work on this didn't have the time to do so and left it open for others. Since nobody seems to be working on this anymore, I wanted to make sure you guys have seen this, since you showed interest on working on this issue.

I think ankidroid is in a dire need of a notification system overhaul, since its practically not very useful and difficult to use (perhaps not really difficult, more like confusing. Its weird to have a widget on the home screen to have notifications to work at all).

Would appreciate if one of you guys or both of you could figure out a better way of implementing notifications for ankidroid.

Thanks!

@eskoONE
Copy link

eskoONE commented Jul 6, 2021

I meant to ping @haran2248 and @prateek-singh-3212, please read the comment above.

Sry about the double post.

@prateek-singh-3212
Copy link
Member

@eskoONE Thanks for reminding me about this issue. Currently their are 3 issues of ankidroid in my todo. But I will take this one because I want to brush up my notification concepts.

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@eskoONE
Copy link

eskoONE commented Feb 16, 2022

@prateek-singh-3212 any news on this?

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@prateek-singh-3212
Copy link
Member

Working on it!!

@github-actions github-actions bot removed the Stale label Jul 2, 2022
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Aug 31, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2022
@david-allison david-allison reopened this Sep 7, 2022
@github-actions github-actions bot removed the Stale label Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jan 6, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants