Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually added audio files to collections.media don't get synced #6485

Closed
4 tasks done
Rapptz opened this issue Jun 17, 2020 · 11 comments
Closed
4 tasks done

Manually added audio files to collections.media don't get synced #6485

Rapptz opened this issue Jun 17, 2020 · 11 comments
Labels
Keep Open avoids the stale bot

Comments

@Rapptz
Copy link
Contributor

Rapptz commented Jun 17, 2020

Reproduction Steps
  1. Save a file to the AnkiDroid collections.media folder
  2. Sync on mobile
  3. Observe that media changes are not found
  4. Sync on desktop
Expected Result

Media files are synced when you go to desktop.

Actual Result

Media files are not synced.

Debug info

AnkiDroid Version = 2.11.2

Android Version = 8.0.0

ACRA UUID = f6428dac-543c-4882-8903-f7504679743c

Research
  • I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • I have searched for similar existing issues here and on the user forum
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
Info

I have an app that generates card using the ContentProvider API. This API works well for me except for the fact that I can't manually add audio. An issue was posted a while ago that got closed to provide for this functionality (#5139). To work around this issue I started adding audio to the collections.media folder. On the desktop version of Anki when you manually add cards to the collections.media folder and sync, the new files are synced to AnkiWeb. I figured that the same would happen with AnkiDroid.

I suspect the bug here is that new changes in the filesystem aren't actually being seen. This was hinted in a comment in the previous issue here.

Note that the audio does play within AnkiDroid so I don't think it's a problem with the actual audio files.

@github-actions
Copy link
Contributor

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

@KieranBrannigan
Copy link
Contributor

I have been working on something like this so I will link my pull request here. #6641

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2020

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Sep 5, 2020
@Rapptz
Copy link
Contributor Author

Rapptz commented Sep 6, 2020

This issue still persists.

@mikehardy
Copy link
Member

Indeed - the PR that provides a real API for it is nearly ready #6641 - in the meantime the workaround is to run a media check after adding files, they should sync after that

@mikehardy mikehardy added the Keep Open avoids the stale bot label Sep 6, 2020
@Rapptz
Copy link
Contributor Author

Rapptz commented Dec 17, 2020

I've noticed that the Instant add-on API hasn't had a version bump in gradle in 3 years or so. Would it be possible to bump it? Certain URIs are inaccessible without it, for example the newly merged FlashCardsContract.AnkiMedia. It could be hardcoded but I think bumping the version might have better developer QoL. I wasn't sure if I should open a new issue for this since it's kind of a follow up to this one.

@mikehardy
Copy link
Member

Mmm 🤔 "a version bump", what exactly do you mean? There are quite a few versions in there, and I bump them all the time https://github.com/ankidroid/Anki-Android/blob/master/api/build.gradle plus a "bump in gradle" means (to me) the android gradle plugin used and/or gradle distribution used, which are both current stable last I checked

@Rapptz
Copy link
Contributor Author

Rapptz commented Dec 18, 2020

Mmm thinking "a version bump", what exactly do you mean?

The version for that has been 1.1.0alpha6 for at least ~2 years so I can't seem to get a more updated version of the package using gradle. It could also be possible that I'm missing something though, android development is more of a side thing for me.

@mikehardy
Copy link
Member

Ah! I see what you mean. That's kind of comical actually.
Honestly, it shouldn't be alpha, it should just be 1.1.0, if you want to PR that I'll happily merge

I'm not even sure if it's release-able in it's current state, by which I mean specifically the build.gradle / maven release machinery, I'm not sure that all works still as it clearly hasn't been used in forever. Probably rusted up pretty good but only one way to find out, and that would be to actually bump version and release it

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@dae
Copy link
Contributor

dae commented Aug 31, 2023

Should be handled by the new backend (if you can even add the files manually anymore, due to scoped storage issues)

@dae dae closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keep Open avoids the stale bot
Projects
None yet
Development

No branches or pull requests

5 participants