Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Keymap/Customizable Keyboard Shortcuts for Reviewer Actions #6052

Closed
david-allison opened this issue Apr 19, 2020 · 8 comments · Fixed by #9460
Closed

[Feature Request] Keymap/Customizable Keyboard Shortcuts for Reviewer Actions #6052

david-allison opened this issue Apr 19, 2020 · 8 comments · Fixed by #9460
Assignees
Labels
Keep Open avoids the stale bot
Milestone

Comments

@david-allison
Copy link
Member

I intend to work on this if accepted. Mentioned in #5430, but I'd like to formalise and confirm plans.


Encompassed: #3021, #1683, #4160, #3600

  • Add a settings screen under Reviewer: Keymap
    • Allow the user to view and remove current keymappings
    • Allow the user to press a button, view the key(s) pressed, and assign it to an action (same as gestures)
    • Include common modifier keys (Ctrl+Alt+Shift)
    • Specify whether an action occurs on the front and/or the back of the card
    • Block duplicate key assignments.
    • Specify whether an action occurs only on the input device used, or on all devices.
    • Specify whether an action is triggered on long/short press (or both if not defined).
    • Add in actions to navigate left/right around the 4 answers of a card.
    • Add in action to explicitly play the front/back of the card (to allow hands-free reviewing and checking of state).
    • Permit handling media events when reviewing cards
    • Stored in a SharedPreferences setting as JSON to allow future schema extensions (is this OK, if so, remove from ACRA logging due to size)?
    • Allow user to specify long press threshold in ms
  • Convert Reviewer to accept commands
  • Listen to KeyUp events, pass them into a KeyEventProcesser, and process the commands obtained.
@mikehardy
Copy link
Member

Your standard video game key assignment screen, yeah? Seems like exactly how everyone else solves it which means either we're all crazy, or we've come to a generic solution and most users are familiar with the style. Tally ho

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@david-allison
Copy link
Member Author

Pending on me getting a few UI diagrams productionised for review.

Settings screen is going to be complex, but I'm not yet happy with how it should look pre-design review.

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Dec 15, 2020
@david-allison david-allison changed the title [Feature Request] Keymap for Reviewer Actions [Feature Request] Keymap/Customizable Keyboard Shortcuts for Reviewer Actions Dec 26, 2020
@github-actions
Copy link
Contributor

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@mikehardy
Copy link
Member

I think this may have some progress here actually #8078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keep Open avoids the stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants