Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency with Anki: show "1000+" new cards instead of exact number #5092

Closed
boolbag opened this issue Nov 4, 2018 · 5 comments · Fixed by #5326
Closed

Consistency with Anki: show "1000+" new cards instead of exact number #5092

boolbag opened this issue Nov 4, 2018 · 5 comments · Fixed by #5326
Assignees

Comments

@boolbag
Copy link

boolbag commented Nov 4, 2018

If you have 1088 new cards in a group, Ankidroid shows "1088" in the New column.
Instead, Anki Windows shows "1000+".

For consistency, how about adopting the "1000+" format?

@mikehardy
Copy link
Member

@timrae this is a taste question but does fall into that "do we conform exactly with upstream or not" category where we usually lean upstream...

@timrae
Copy link
Member

timrae commented Nov 5, 2018

Can you post a screenshot of desktop to be clear exactly what you're talking about?

@werkn
Copy link
Contributor

werkn commented Dec 6, 2018

@timrae @mikehardy
I didn't open the issue but I just populated a dummy deck on the desktop app and the following is the appearance for a deck having 1500 cards in it.

New Cards

capture

Due Cards

capture2

Seems fairly trivial and if you decide on moving forward I would be happy to provide a fix.

@mikehardy
Copy link
Member

I like the general rule of "we do what Anki Desktop does" with reasonable exceptions for things that are platform-specific, because it makes it easy to rule yea or nay on issues and keep our issues list clean. It seems like it makes it more difficult to justify applying the rule when closing an enhancement request when there are obvious opportunities like this to conform, so I would go for the fix as a vote. But I'm only really explaining my reasoning because @timrae is the ax here - years more history and wisdom keeping things tasteful, so I'm more curious on his take on my reasoning, and what he thinks on this issue. I'd wait for his take.

@timrae
Copy link
Member

timrae commented Dec 16, 2018

Is this new behaviour on desktop? I didn't notice it before, that might just be because I've never set my study limits that high though. There is another place in the app where we decided not to follow desktop behaviour on this specific issue. If I understand correctly, the large values will only be shown when the user explicitly uses extremely large values for the limits. In such a case I would imagine they want to see the actual number...? What's the rationale for hiding them other than just following Anki desktop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants