Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review counts are limited by 1000 #2226

Closed
hssm opened this issue Jul 28, 2015 · 4 comments
Closed

Review counts are limited by 1000 #2226

hssm opened this issue Jul 28, 2015 · 4 comments

Comments

@hssm
Copy link
Member

hssm commented Jul 28, 2015

Originally reported on Google Code with ID 1324

What steps will reproduce the problem?
1. Get more than 1000 reviews in any deck.
2. Set the limit of reviews in that deck to 9999.
3. When the deck is selected, the counts above the graph display the right figures.
But the number in the deck list is 1000. Anki Desctop displays 1000+ in this case,
not 1000 exactly.
4. The figure in the AnkiDroid window title is the sum of cards to be learned and 1000,
which has nothing to do with actual counts and might be mesleading.
5. This number is propagated to the widget on the desktop.

I would like to see these figures not limited by 1000. I really often have a backlog
of a few thousands, so I need to know the right figures.

If the figures have to be limited, they shouldn't be displayed in the program title
and in the widget as they are misleading.


Happens everytime.

AnkiDroid 2.0 beta 14
Android 4.0.3

Reported by ovgolovin on 2012-08-14 19:56:28


- _Attachment: [VIDEO0097.mp4](https://storage.googleapis.com/google-code-attachments/ankidroid/issue-1324/comment-0/VIDEO0097.mp4)_
@hssm
Copy link
Member Author

hssm commented Jul 28, 2015

I don't remember exactly but I think it was on purpose (performance?).
I suggest displaying "1000+", that would be less confusing indeed.

Reported by nicolas.raoul on 2012-08-23 02:35:43

  • Status changed: Accepted
  • Labels added: Type-Enhancement, Priority-Medium
  • Labels removed: Type-Defect, Priority-Undecided

@hssm
Copy link
Member Author

hssm commented Jul 28, 2015

Is this limit essential at all? The upper bound for reviews or new cards is either way
9999 (four digits).
I frequently have to review more than 1000 cards in a deck in a single day, so it would
be nice to show up all the numbers in the deck picker.
Counting 9999 cards takes 52 ms on my device. It is significantly longer than on small
decks but maybe we can live with that?

Reported by nikkou.postbox on 2014-10-10 14:35:10

@hssm
Copy link
Member Author

hssm commented Jul 28, 2015

As I know, this number 1000 was chosen by Damien Elmes, the author of Anki-desktop,
which is hardcoded in many places in Anki-desktop code.
I was trying to write a plugin (for Anki-desktop) to raise this limit, and it even
worked for some time, but after that it stopped working. It was because this limit
was used in sanity check after syncing, and it was hardcoded even there. So in the
end I decided to stop my attempts.

Reported by ovgolovin on 2014-10-10 18:42:59

@hssm
Copy link
Member Author

hssm commented Jul 28, 2015

Reported by perceptualchaos2 on 2015-06-02 09:28:05

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant