Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update notification if count has not changed #1523

Closed
hssm opened this issue Jul 28, 2015 · 4 comments
Closed

Do not update notification if count has not changed #1523

hssm opened this issue Jul 28, 2015 · 4 comments
Labels
Accepted Maintainers welcome a PR implementing this feature Bug Priority-Medium

Comments

@hssm
Copy link
Member

hssm commented Jul 28, 2015

Originally reported on Google Code with ID 620

Currently, the notification of due cards is updated even if the number of cards has
not changed.
We should store the last shown count and update it only if it has changed.

Reported by flerda on 2011-05-05 06:23:46

@hssm
Copy link
Member Author

hssm commented Jul 28, 2015

Reported by nicolas.raoul on 2011-08-30 02:13:35

  • Labels removed: Milestone-Release0.7

@hssm hssm added Bug Priority-Medium Accepted Maintainers welcome a PR implementing this feature labels Jul 28, 2015
@hssm
Copy link
Member Author

hssm commented Jul 28, 2015

Did you mean a cache for the deck counts? Is it really necessary?

Reported by perceptualchaos2 on 2015-06-01 05:20:39

@wchristian
Copy link

Yes please, this is needed, since otherwise notifications relentlessly buzz again and again on every notification update, even when the app itself is open, despite a lack of changes.

@mikehardy
Copy link
Member

#4944 - related to notifications work I'm doing now - notifications should go away while the app is open, and when it closes they should maybe go back once but without vibration if the user didn't clear the counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Maintainers welcome a PR implementing this feature Bug Priority-Medium
Projects
None yet
Development

No branches or pull requests

3 participants