Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Build sqlite.proto in Anki-Android-Backend #21

Closed
david-allison opened this issue Jan 23, 2021 · 3 comments · Fixed by #202
Closed

chore: Build sqlite.proto in Anki-Android-Backend #21

david-allison opened this issue Jan 23, 2021 · 3 comments · Fixed by #202
Assignees
@david-allison
Labels
enhancement New feature or request

Comments

@david-allison
Copy link
Member

This removes an AnkiDroid-specific feature from /anki, which moves it closer to upstream and means we don't need to rebuild the library when making an AnkiDroid specific change.

  • Add protobuf generation code into rslib-bridge/build.rs
  • Enable building Java-based protobufs from Anki-Android-Backend
@david-allison david-allison added the enhancement New feature or request label Jan 23, 2021
@david-allison
Copy link
Member Author

david-allison/anki@8a08206

david-allison/anki@ad1f9c9

DBResponse can be moved entirely to AnkiDroid

@david-allison david-allison self-assigned this Jan 25, 2021
@david-allison
Copy link
Member Author

david-allison commented Jan 25, 2021 •
edited
Loading

Required for ankidroid/Anki-Android#5805

Our underlying Anki implementation is past schema 14, which stored config in a separate table and retrieves data for the sched_timing_today call via the Rust.

We need to define a legacy sched_timing_today which accepts a SchedTimingTodayIn, rather than obtaining the data from the config.

@david-allison
Copy link
Member Author

david-allison commented Jan 25, 2021 •
edited
Loading

Partially implemented in AdBackend.proto

We do not currently link backend.proto and AdBackend.proto so switching a message with a dependency currently isn't handled

@david-allison david-allison mentioned this issue Apr 1, 2021
Closed
@dae dae mentioned this issue Jun 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-allison david-allison

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to use Anki 2.1.54's code ankitects/Anki-Android-Backend
1 participant
@david-allison