From 8cd7d96514f21d575fd82017788d5fd1e80ceed3 Mon Sep 17 00:00:00 2001 From: anjakefala Date: Tue, 15 Oct 2024 13:30:07 -0700 Subject: [PATCH] Felipe PR comments --- cpp/src/arrow/chunk_resolver.h | 16 ++++++++-------- cpp/src/arrow/chunk_resolver_benchmark.cc | 3 --- cpp/src/arrow/chunked_array_test.cc | 4 ---- cpp/src/arrow/compute/kernels/vector_sort.cc | 1 - 4 files changed, 8 insertions(+), 16 deletions(-) diff --git a/cpp/src/arrow/chunk_resolver.h b/cpp/src/arrow/chunk_resolver.h index 457a5277c9014..20718677599a2 100644 --- a/cpp/src/arrow/chunk_resolver.h +++ b/cpp/src/arrow/chunk_resolver.h @@ -290,12 +290,12 @@ class ARROW_EXPORT ChunkResolver { }; // Explicitly instantiate template base struct, for DLL linking on Windows -template struct arrow::TypedChunkLocation; -template struct arrow::TypedChunkLocation; -template struct arrow::TypedChunkLocation; -template struct arrow::TypedChunkLocation; -template struct arrow::TypedChunkLocation; -template struct arrow::TypedChunkLocation; -template struct arrow::TypedChunkLocation; -template struct arrow::TypedChunkLocation; +template struct TypedChunkLocation; +template struct TypedChunkLocation; +template struct TypedChunkLocation; +template struct TypedChunkLocation; +template struct TypedChunkLocation; +template struct TypedChunkLocation; +template struct TypedChunkLocation; +template struct TypedChunkLocation; } // namespace arrow diff --git a/cpp/src/arrow/chunk_resolver_benchmark.cc b/cpp/src/arrow/chunk_resolver_benchmark.cc index 786075f2fc863..a6f539a444bbc 100644 --- a/cpp/src/arrow/chunk_resolver_benchmark.cc +++ b/cpp/src/arrow/chunk_resolver_benchmark.cc @@ -28,9 +28,6 @@ namespace arrow { -using arrow::ChunkResolver; -using arrow::TypedChunkLocation; - namespace { int64_t constexpr kChunkedArrayLength = std::numeric_limits::max(); diff --git a/cpp/src/arrow/chunked_array_test.cc b/cpp/src/arrow/chunked_array_test.cc index 62aff78b48035..b3944fd1b1927 100644 --- a/cpp/src/arrow/chunked_array_test.cc +++ b/cpp/src/arrow/chunked_array_test.cc @@ -36,10 +36,6 @@ namespace arrow { -using arrow::ChunkLocation; -using arrow::ChunkResolver; -using arrow::TypedChunkLocation; - class TestChunkedArray : public ::testing::Test { protected: virtual void Construct() { diff --git a/cpp/src/arrow/compute/kernels/vector_sort.cc b/cpp/src/arrow/compute/kernels/vector_sort.cc index 15fafa1f4d219..395ed86a06b4a 100644 --- a/cpp/src/arrow/compute/kernels/vector_sort.cc +++ b/cpp/src/arrow/compute/kernels/vector_sort.cc @@ -23,7 +23,6 @@ namespace arrow { -using arrow::ChunkLocation; using internal::checked_cast; namespace compute {