Add support for annotations in visualization #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! This does exactly what I had in mind. Can't wait to test it. |
|
Please let me know when you get a chance to test this — I would like to confirm that the API works for you before merging/releasing this addition to the public API of Porcupine. |
|
Sorry, I didn't know you wanted for etcd testing the feature, I'm pretty busy this week, but maybe someone else from etcd community can help. Filled etcd-io/etcd#17988 |
|
There's no rush on my end, happy to hear your feedback whenever you have time |
anishathalye
force-pushed
the
annotations
branch
from
4d2f9bd
to
56b2789
Compare
|
Squashed and merged in 12c3848. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See documentation for
LinearizationInfo.AddAnnotationsand the newAnnotationtype.Example:
[view interactive version]