Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solar radius and solar temperature units #683

Merged
merged 17 commits into from
Jul 21, 2019

Conversation

ebfortin
Copy link
Contributor

Continuation of work on adding astronomy units to UnitsNet.

@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #683 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
+ Coverage   55.56%   55.58%   +0.02%     
==========================================
  Files         164      164              
  Lines       37408    37426      +18     
==========================================
+ Hits        20786    20804      +18     
  Misses      16622    16622
Impacted Files Coverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs 100% <ø> (ø) ⬆️
UnitsNet/GeneratedCode/UnitConverter.g.cs 100% <100%> (ø) ⬆️
UnitsNet/GeneratedCode/Quantities/Temperature.g.cs 51.13% <100%> (+1.13%) ⬆️
UnitsNet/GeneratedCode/Quantities/Length.g.cs 91.03% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c58f2...e7ab7db. Read the comment docs.

@angularsen
Copy link
Owner

I'm not going to force you to, but I advise you to look into GitHub's recipe for doing pull requests from forks. Basically, you are now working on your fork's master branch, but you should instead work on feature branches so that the pull request only contains the commits you want to merge. Right now you have all the commits from the previous pull request in here as well. It makes not much of a practical difference since the old changes are merged already, but it does make the pull request a lot more easy to review now and for future pull requests.

https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

My preferred way of doing it:

  • Add two origins in git: my as your fork, origin as the angularsen repo
  • Create and checkout a branch add-solar-ratio based on your master to get all the changes
  • Rebase it interactively on top of origin/master and remove all the unrelated commits
  • Push add-solar-ratio to your fork and create a pull request from it
  • Remove your master branch, you should really only need the remote branch origin/master for most usecases

@ebfortin
Copy link
Contributor Author

I kind of look likes a newbie :) I know Git well but never contributed to another project like this. I will restructure my things accordingly.

@angularsen
Copy link
Owner

No worries :-) I'll just merge this since it seems ready to go. I will squash the commits down to a single merge commit anyway so it does not matter. But for future pull requests, it would be good if you created new feature branches as explained.

@angularsen angularsen merged commit 5bc1b70 into angularsen:master Jul 21, 2019
@angularsen angularsen changed the title Adding Solar radius ratio to Length quantity Add solar radius and solar temperature units Jul 21, 2019
@angularsen
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants