-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solar radius and solar temperature units #683
Conversation
DO NOT CURRENTLY COMPILE!
Merge from origin
All tests passes.
Added units for Astronomy. (angularsen#680)
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
+ Coverage 55.56% 55.58% +0.02%
==========================================
Files 164 164
Lines 37408 37426 +18
==========================================
+ Hits 20786 20804 +18
Misses 16622 16622
Continue to review full report at Codecov.
|
I'm not going to force you to, but I advise you to look into GitHub's recipe for doing pull requests from forks. Basically, you are now working on your fork's master branch, but you should instead work on feature branches so that the pull request only contains the commits you want to merge. Right now you have all the commits from the previous pull request in here as well. It makes not much of a practical difference since the old changes are merged already, but it does make the pull request a lot more easy to review now and for future pull requests. https://help.github.com/en/articles/creating-a-pull-request-from-a-fork My preferred way of doing it:
|
I kind of look likes a newbie :) I know Git well but never contributed to another project like this. I will restructure my things accordingly. |
No worries :-) I'll just merge this since it seems ready to go. I will squash the commits down to a single merge commit anyway so it does not matter. But for future pull requests, it would be good if you created new feature branches as explained. |
Continuation of work on adding astronomy units to UnitsNet.