Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Nominal Solar Radius as defined in IAU Res. B3 #1425

Closed
saadsidqui opened this issue Sep 22, 2024 · 0 comments · Fixed by #1426
Closed

Use the Nominal Solar Radius as defined in IAU Res. B3 #1425

saadsidqui opened this issue Sep 22, 2024 · 0 comments · Fixed by #1426
Labels
bug

Comments

@saadsidqui
Copy link
Contributor

saadsidqui commented Sep 22, 2024 •
edited by angularsen
Loading

Describe the bug
The current value of 6.95510e8 differs from the standardized nominal solar radius value 6.95700e8 defined in IAU Resolution B3 (2015) [Also on Wikipedia]

To Reproduce
See Length.json#L384 and Length.json#L385

Expected behavior
The definitions should be updated to the correct value:

      "FromUnitToBaseFunc": "{x} * 6.95700e8",
      "FromBaseToUnitFunc": "{x} / 6.95700e8",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨Update Length.SolarRadius definition per IAU Res. B3 saadsidqui/UnitsNet
1 participant
@saadsidqui