refactor!: fixing all static analysis warnings #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GZGavinZhao I think we need to bump the minimal SDK version to |
|
@ykmnkmi I'm okay with it. You also might need to lock |
GZGavinZhao
changed the title
|
Oh also, if you would like to sign your commits when your PR is ready that would be great. So far I've been squashing the commits and signing them using my keys (which is why you sometimes see commits are authored by you but committed by me), and I'm happy to keep doing so, but if it's convenient for you to sign them then that would be great :) |
|
@GZGavinZhao thanks for helping with commits and PR's. |
ykmnkmi
force-pushed
the
static-analysis-warnings
branch
from
dd5d284
to
7585767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.