From 6f9a2abbf7d16f35e342f963543706ff3e1c45a1 Mon Sep 17 00:00:00 2001 From: mgiambalvo Date: Wed, 4 Jan 2017 14:51:41 -0800 Subject: [PATCH] fix(gecko): Respect versions.gecko in start command. (#184) Also bump the geckodriver version to latest. --- config.json | 2 +- lib/cmds/start.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/config.json b/config.json index 77f122ea..9a020857 100644 --- a/config.json +++ b/config.json @@ -2,7 +2,7 @@ "webdriverVersions": { "selenium": "2.53.1", "chromedriver": "2.26", - "geckodriver": "v0.11.1", + "geckodriver": "v0.12.0", "iedriver": "2.53.1", "androidsdk": "24.4.1", "appium": "1.6.0" diff --git a/lib/cmds/start.ts b/lib/cmds/start.ts index 41a8768e..a173ba08 100644 --- a/lib/cmds/start.ts +++ b/lib/cmds/start.ts @@ -26,6 +26,7 @@ let prog = new Program() .addOption(Opts[Opt.AVD_PORT]) .addOption(Opts[Opt.VERSIONS_STANDALONE]) .addOption(Opts[Opt.VERSIONS_CHROME]) + .addOption(Opts[Opt.VERSIONS_GECKO]) .addOption(Opts[Opt.VERSIONS_ANDROID]) .addOption(Opts[Opt.VERSIONS_APPIUM]) .addOption(Opts[Opt.CHROME_LOGS]) @@ -108,6 +109,7 @@ function start(options: Options) { } binaries[StandAlone.id].versionCustom = options[Opt.VERSIONS_STANDALONE].getString(); binaries[ChromeDriver.id].versionCustom = options[Opt.VERSIONS_CHROME].getString(); + binaries[GeckoDriver.id].versionCustom = options[Opt.VERSIONS_GECKO].getString(); if (options[Opt.VERSIONS_IE]) { binaries[IEDriver.id].versionCustom = options[Opt.VERSIONS_IE].getString(); }