diff --git a/lib/cmds/initialize.ts b/lib/cmds/initialize.ts index 66006060..8851dd8d 100644 --- a/lib/cmds/initialize.ts +++ b/lib/cmds/initialize.ts @@ -245,8 +245,9 @@ export function android( 'android-sdk: Downloading more additional SDK updates ' + '(this may take a while)'); return downloadAndroidUpdates( - sdkPath, ['build-tools-24.0.0'].concat( - getAndroidSDKTargets(apiLevels, architectures, platforms, oldAVDs)), + sdkPath, + ['build-tools-24.0.0'].concat( + getAndroidSDKTargets(apiLevels, architectures, platforms, oldAVDs)), true, acceptLicenses, verbose); }) .then(() => { diff --git a/lib/cmds/opts.ts b/lib/cmds/opts.ts index ff9d9c5d..fde3795c 100644 --- a/lib/cmds/opts.ts +++ b/lib/cmds/opts.ts @@ -105,7 +105,8 @@ opts[STARTED_SIGNIFIER] = new Option( 'A string to be outputted once the selenium server is up and running. Useful if you are writing a script which uses webdriver-manager.', 'string'); opts[SIGNAL_VIA_IPC] = new Option( - SIGNAL_VIA_IPC, 'If you are using --' + STARTED_SIGNIFIER + + SIGNAL_VIA_IPC, + 'If you are using --' + STARTED_SIGNIFIER + ', this flag will emit the signal string using process.send(), rather than writing it to stdout', 'boolean', false); opts[DETACH] = new Option( diff --git a/lib/cmds/start.ts b/lib/cmds/start.ts index 91ccb84a..120b0ffc 100644 --- a/lib/cmds/start.ts +++ b/lib/cmds/start.ts @@ -130,7 +130,6 @@ function start(options: Options) { // https://bugs.openjdk.java.net/browse/JDK-6202721 args.push('-Djava.security.egd=file:///dev/./urandom'); } - if (options[Opt.LOGGING].getString()) { if (path.isAbsolute(options[Opt.LOGGING].getString())) { loggingFile = options[Opt.LOGGING].getString(); @@ -154,14 +153,14 @@ function start(options: Options) { path.resolve(outputDir, binaries[GeckoDriver.id].executableFilename(osType))); } if (downloadedBinaries[IEDriver.id] != null) { - if (options[Opt.IE32]) { + if (options[Opt.IE32].getBoolean()) { binaries[IEDriver.id].arch = 'Win32'; } args.push( '-Dwebdriver.ie.driver=' + path.resolve(outputDir, binaries[IEDriver.id].executableFilename(osType))); } - if (options[Opt.EDGE]) { + if (options[Opt.EDGE] && options[Opt.EDGE].getString()) { // validate that the file exists prior to adding it to args try { let edgeFile = options[Opt.EDGE].getString();