Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add missing globals #992

Closed
CaerusKaru opened this issue May 17, 2018 · 3 comments
Closed

feat(common): add missing globals #992

CaerusKaru opened this issue May 17, 2018 · 3 comments

Comments

@CaerusKaru
Copy link
Member

CaerusKaru commented May 17, 2018

I'm submitting a ...

- [ ] bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
- [x] feature request
- [ ] Support request => Please do not submit support request here, instead see https://github.com/angular/universal/blob/master/CONTRIBUTING.md#question

What modules are related to this Issue?

- [ ] aspnetcore-engine
- [x] common
- [ ] express-engine
- [ ] hapi-engine
- [ ] module-map-ngfactory-loader

Current behavior?

Globals like document and window are available in Domino, but are not patched before app render

Expected behavior?

These globals should be available to applications and libraries during render, via a proxy patch (so that each request gets its own document and window)

Minimal reproduction with instructions

Access document.body in any part of the application

Environment:

@nguniversal versions

  • common: 6.0.0
@friday
Copy link

friday commented Jul 28, 2018

We (mostly me) talked about this issue in: video-dev/hls.js#1841 (comment)

This information could be relevant to you as well (the caveats part). Or if you disagree with them, you could tell me why I'm wrong 😉

Also see

@alan-agius4
Copy link
Collaborator

Closing as accessing document and window directly is not recommended and should not be encouraged.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants