fix(datepicker): changed after checked error if focused datepicker inputs turn disabled #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…puts turn disabled In some situations, the `disable()` method of a form control is called while the datepicker input is focused. This causes a changed after checked error. Normally, native input elements automatically blur if they turn disabled. This behavior is problematic, because it would mean that it triggers another change detection cycle, which then causes a changed after checked error if the input element was focused before. Fixes angular#9559
devversion
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Jan 31, 2018
mmalerba
pushed a commit
that referenced
this pull request
Feb 8, 2018
…puts turn disabled (#9717) In some situations, the `disable()` method of a form control is called while the datepicker input is focused. This causes a changed after checked error. Normally, native input elements automatically blur if they turn disabled. This behavior is problematic, because it would mean that it triggers another change detection cycle, which then causes a changed after checked error if the input element was focused before. Fixes #9559
tinayuangao
pushed a commit
that referenced
this pull request
Feb 9, 2018
…puts turn disabled (#9717) In some situations, the `disable()` method of a form control is called while the datepicker input is focused. This causes a changed after checked error. Normally, native input elements automatically blur if they turn disabled. This behavior is problematic, because it would mean that it triggers another change detection cycle, which then causes a changed after checked error if the input element was focused before. Fixes #9559
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, the
disable()method of a form control is called while the datepicker input is focused. This causes a changed after checked error.Normally, native input elements automatically blur if they turn disabled. This behavior is problematic, because it would mean that it triggers another change detection cycle, which then causes a changed after checked error if the input element was focused before.
Fixes #9559