fix(overlay): expose event object in backdropClick stream #9716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes the click event object when subscribing to the `OverlayRef.backdropClick` stream. Fixes angular#9713.
crisbeto
requested review from
andrewseguin,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 31, 2018
| @@ -62,7 +62,7 @@ export class DialogRef<T, R = any> { | |||
| } | |||
|
|
|||
| /** Gets an observable that emits when the overlay's backdrop has been clicked. */ | |||
| backdropClick(): Observable<void> { | |||
| backdropClick(): Observable<MouseEvent> { | |||
There was a problem hiding this comment.
Could this ever be a TouchEvent?
There was a problem hiding this comment.
Nope, AFAIK mobile browsers just fake it as a MouseEvent.
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 1, 2018
Exposes the click event object when subscribing to the `OverlayRef.backdropClick` stream. Fixes angular#9713.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the click event object when subscribing to the
OverlayRef.backdropClickstream.Fixes #9713.