fix(menu): always focus first menu item #9383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: needs review
Accessibility
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 16, 2018
src/lib/menu/menu-directive.ts
Outdated
| */ | ||
| focusFirstItem() { | ||
| this._keyManager.setFirstItemActive(); | ||
| focusFirstItem(origin: FocusOrigin) { |
There was a problem hiding this comment.
Should this be option to avoid a breaking change?
| super(); | ||
|
|
||
| if (_focusMonitor) { |
There was a problem hiding this comment.
Add a comment here like
// We want to show the focus style for menu items only when the focus was not caused by
// a mouse or touch interaction. ?
crisbeto
force-pushed
the
9252/menu-item-focus-origin
branch
from
5879ffb
to
757e482
Compare
|
Addressed the feedback @jelbourn. |
|
Actually it looks like CircleCI is raising a compilation error |
crisbeto
force-pushed
the
9252/menu-item-focus-origin
branch
from
757e482
to
e59df4f
Compare
|
ops, it's sorted out now. |
jelbourn
added
pr: lgtm
action: merge
* Switches to always focusing the first menu item, even when opening by mouse. The focus styling will only apply when focused by keyboard. * Adds the ability to set the focus origin through the `FocusKeyManager`. Fixes angular#9252.
crisbeto
force-pushed
the
9252/menu-item-focus-origin
branch
from
e59df4f
to
4a8bf7d
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 23, 2018
Fixes an e2e test that is failing after angular#9383.
jelbourn
pushed a commit
that referenced
this pull request
Jan 23, 2018
Fixes an e2e test that is failing after #9383.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 24, 2018
Fixes an e2e test that is failing after #9383.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
Fixes an e2e test that is failing after angular#9383.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FocusKeyManager.Fixes #9252.