Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-spinner and md-progress-circle indeterminate are blinking #926

Closed
benfuu opened this issue Jul 27, 2016 · 2 comments · Fixed by #927
Closed

md-spinner and md-progress-circle indeterminate are blinking #926

benfuu opened this issue Jul 27, 2016 · 2 comments · Fixed by #927
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@benfuu
Copy link

benfuu commented Jul 27, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The spinner is supposed to have a smooth animation.

What is the current behavior?

Using the most recent commit, the progress spinner is blinking.

What are the steps to reproduce?

See the demo app:
https://material2-test.firebaseapp.com/progress-circle

Pull from the latest commit, and put a spinner/indeterminate circle into your app:
<md-progress-circle mode="indeterminate"></md-progress-circle>

or

<md-spinner></md-spinner>

What is the use-case or motivation for changing an existing behavior?

Fix the issue before it gets deployed.

Which versions of Angular, Material, OS, browsers are affected?

AngularJs 2: 2.0.0-rc.4
Angular 2 Material: Current version from git

Is there anything else we should know?

The progress-circle is working normally for version 2.0.0-alpha.6-2 so not exactly sure what is causing it right now. In fact, I'm not even sure if this is just a weird bug that'll get fixed with the next deployment but I just thought that you guys should know that it's happening.

Thanks!

crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 28, 2016
Fixes the progress circle animation not working, because the calculations weren't correct. When 14c1765 was introduced, one of the values uses the time since epoch, whereas the other one is the time since the page was opened.

Fixes angular#926.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 28, 2016
Fixes the progress circle animation not working, because the calculations weren't correct. When 14c1765 was introduced, one of the values uses the time since epoch, whereas the other one is the time since the page was opened.

Fixes angular#926.
@jelbourn
Copy link
Member

Wow, that's pretty glaring. How did we not see this...

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround has pr labels Jul 28, 2016
jelbourn pushed a commit that referenced this issue Aug 4, 2016
Fixes the progress circle animation not working, because the calculations weren't correct. When 14c1765 was introduced, one of the values uses the time since epoch, whereas the other one is the time since the page was opened.

Fixes #926.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants