fix(expansion-panel): improved accessibility labelling and keyboard default action not being prevented #9174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault action not being prevented Adds the following improvements to the expansion accessibility, based on the [accessible accordion guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordion.html): * Adds the `region` role to the content element. * Adds `aria-labelledby` pointing to the header. * Fixes the page being scrolled down when a panel is opened using space. The issue was that we were preventing the default action during `keydown` which is too late in the lifecycle. Also adds a couple of extra tests for the keyboard controls.
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 29, 2018
…efault action not being prevented (angular#9174) Adds the following improvements to the expansion accessibility, based on the [accessible accordion guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordion.html): * Adds the `region` role to the content element. * Adds `aria-labelledby` pointing to the header. * Fixes the page being scrolled down when a panel is opened using space. The issue was that we were preventing the default action during `keydown` which is too late in the lifecycle. Also adds a couple of extra tests for the keyboard controls.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following improvements to the expansion accessibility, based on the accessible accordion guidelines:
regionrole to the content element.aria-labelledbypointing to the header.keydownwhich is too late in the lifecycle.Also adds a couple of extra tests for the keyboard controls.