Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slide-toggle): truncate label content with ellipsis #9166

Merged
merged 1 commit into from
Jan 23, 2018
Merged

fix(slide-toggle): truncate label content with ellipsis #9166

merged 1 commit into from
Jan 23, 2018

Conversation

devversion
Copy link
Member

  • Instead of showing the text overflow of slide-toggle content, an ellipsis for too long labels will be shown.

Fixes #5212

@devversion
fix(slide-toggle): truncate label content with ellipsis
d751ee7 
* Instead of showing the text overflow of slide-toggle content, an ellipsis for too long labels will be shown.

Fixes angular#5212
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2017
@jelbourn
Copy link
Member

To clarify- the content will still grow up to the size of its parent container, but now won't overflow its parent container, yes?

@devversion
Copy link
Member Author

devversion commented Jan 12, 2018 •
edited
Loading

Yeah, the slide-toggle will grow horizontally as big as the parent container allows. If it exceeds, overflow will be hidden, and an ellipsis will be shown.

jelbourn
jelbourn approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 12, 2018
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jan 17, 2018
@jelbourn jelbourn merged commit 68bb44c into angular:master Jan 23, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
@devversion @jelbourn
fix(slide-toggle): truncate label content with ellipsis (angular#9166)
4bd96ce 
* Instead of showing the text overflow of slide-toggle content, an ellipsis for too long labels will be shown.

Fixes angular#5212
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve slide-toggle text label
4 participants
@devversion @jelbourn @crisbeto @googlebot