fix(accordion-item): emitting closed event while closed #9101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean. Fixes angular#9098.
crisbeto
force-pushed
the
accordion-item-closed-emit
branch
from
afe9685
to
33623f3
Compare
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
…#9101) Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean. Fixes angular#9098.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
…#9101) Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean. Fixes angular#9098.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean. Fixes #9098.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the `expanded` property defaulting to `undefined`. Also includes making a few of the tests a bit more strict to ensure that the `expanded` property is always a boolean. Fixes #9098.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the accordion item emitting its closed event once, even if it is closed. It is due to the
expandedproperty defaulting toundefined. Also includes making a few of the tests a bit more strict to ensure that theexpandedproperty is always a boolean.Fixes #9098.