Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Animation doesn't match spec #8953

Closed
vladimir-barsuchenko opened this issue Dec 12, 2017 · 8 comments · Fixed by #9134
Closed

[Menu] Animation doesn't match spec #8953

vladimir-barsuchenko opened this issue Dec 12, 2017 · 8 comments · Fixed by #9134
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@vladimir-barsuchenko
Copy link

vladimir-barsuchenko commented Dec 12, 2017 •
edited
Loading

Bug, feature request, or proposal:

Bug / Proposal

What is the expected behavior?

To have panel animation match specs.
Material Components For Web
Material Design

What is the current behavior?

Mat menu-content opacity duration is shorter than in specs.
Menu is shown almost without opacity transition. And I can see how content is transformed (stretched).
Also menu has X position animated which is different from specs

What are the steps to reproduce?

https://stackblitz.com/angular/mjvedxgkvqg

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular v5.1. Material v.5.1

Is there anything else we should know?
@vladimir-barsuchenko vladimir-barsuchenko changed the title fadeInItems & fadeInContent doesn't work Mat-menu opacity transition is very short Dec 12, 2017
@julianobrasil
Copy link
Contributor

Your stackblitz link is broken.

@vladimir-barsuchenko
Copy link
Author

updated

@willshowell
Copy link
Contributor

The animation was changed in #5361 to better match the spec examples

@vladimir-barsuchenko
Copy link
Author

vladimir-barsuchenko commented Dec 12, 2017 •
edited
Loading

@willshowell could you elaborate? Because links say different:
Material Components For Web
Material Design

@vladimir-barsuchenko vladimir-barsuchenko changed the title Mat-menu opacity transition is very short Mat-menu animation don't match specs Dec 12, 2017
@vladimir-barsuchenko vladimir-barsuchenko changed the title Mat-menu animation don't match specs Mat-menu animation doesn't match specs Dec 12, 2017
@willshowell
Copy link
Contributor

I think they follow the material.io guidelines, not the material-components implementation.

While I do believe the new animation better matches the spec, the animation here does seem to be different from the current implementation. It seems like the content opacity animation needs to be delayed slightly more...

https://github.com/angular/material2/blob/2fb4d618725b6fddc1a94e5e85ea80577377f1eb/src/lib/menu/menu-animations.ts#L55-L65

@crisbeto
Copy link
Member

If you're running Angular 5.1, the opacity won't be animated due to an issue with @angular/animations. See angular/angular#20946.

@vladimir-barsuchenko
Copy link
Author

@crisbeto, cool. Waiting for a fix then

@andrewseguin andrewseguin changed the title Mat-menu animation doesn't match specs [Menu] Animation doesn't match spec Dec 12, 2017
@jelbourn jelbourn assigned crisbeto and unassigned jelbourn Dec 12, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 27, 2017
@crisbeto
fix(expansion-panel,menu,select): nested animations not working
4b79804 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814, angular#8953.
@crisbeto crisbeto mentioned this issue Dec 27, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 27, 2017
@crisbeto
fix(expansion-panel,menu,select): nested animations not working
0854c4f 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed blocked labels Dec 27, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 8, 2018
@crisbeto
fix(expansion-panel,menu,select): nested animations not working
a2700b2 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
jelbourn pushed a commit that referenced this issue Jan 21, 2018
@crisbeto @jelbourn
fix(expansion-panel,menu,select): nested animations not working
05da397 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 23, 2018
@crisbeto
fix(expansion-panel,menu,select): nested animations not working
bf2969a 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 17, 2018
@crisbeto
fix(expansion-panel,menu,select): nested animations not working
d8fb778 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes angular#8814.
Fixes angular#8953.
andrewseguin pushed a commit that referenced this issue Feb 20, 2018
@crisbeto @andrewseguin
fix(expansion-panel,menu,select): nested animations not working (#9134)
1e2b79a 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.
tinayuangao pushed a commit that referenced this issue Feb 20, 2018
@crisbeto @tinayuangao
fix(expansion-panel,menu,select): nested animations not working (#9134)
342e3c6 
Fixes issues with the expansion panel, menu and select animations where the child animations were being blocked by the parent ones.

**Note:** the menu animations needed a bit more refactoring since the old approach wasn't very idiomatic and made it harder to run the parallel animations.

Fixes #8814.
Fixes #8953.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(expansion-panel,menu,select): nested animations not working crisbeto/material2
5 participants
@jelbourn @crisbeto @willshowell @vladimir-barsuchenko @julianobrasil