Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip removal via click event inside MatSelect results in an onOpen event #8771

Closed
yoonjesung opened this issue Dec 2, 2017 · 1 comment · Fixed by #8772
Closed

Chip removal via click event inside MatSelect results in an onOpen event #8771

yoonjesung opened this issue Dec 2, 2017 · 1 comment · Fixed by #8772
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@yoonjesung
Copy link

Bug, feature request, or proposal:

feature request

What is the expected behavior?

Removing a chip that is inside a mat-select as part of the mat-select-trigger through a click event should remove the chip without causing the mat-select to open .

What is the current behavior?

mat-select opens when removing a chip.

What are the steps to reproduce?

http://plnkr.co/edit/I2txATmD4jtI7U3zOguv?p=preview

What is the use-case or motivation for changing an existing behavior?

UX

Is there anything else we should know?

Only occurs on click events. Removing the chip via BACKSPACE or DELETE does not fire an onOpen event
@crisbeto crisbeto self-assigned this Dec 2, 2017
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Dec 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 2, 2017
@crisbeto
fix(chips): event propagation not stopped by remove button
400c667 
Fixes clicking on the chip remove button propagating up and potentially triggering its parent control. This is usually handled by the chip itself, however clicking on the button could remove the chip before it has the chance to stop propagation.

Fixes angular#8771.
@crisbeto crisbeto mentioned this issue Dec 2, 2017
Merged
andrewseguin pushed a commit that referenced this issue Dec 13, 2017
@crisbeto @andrewseguin
fix(chips): event propagation not stopped by remove button (#8772)
c7e2d4e 
Fixes clicking on the chip remove button propagating up and potentially triggering its parent control. This is usually handled by the chip itself, however clicking on the button could remove the chip before it has the chance to stop propagation.

Fixes #8771.
andrewseguin pushed a commit to andrewseguin/components that referenced this issue Dec 19, 2017
@crisbeto @andrewseguin
fix(chips): event propagation not stopped by remove button (angular#8772
0236623 
)

Fixes clicking on the chip remove button propagating up and potentially triggering its parent control. This is usually handled by the chip itself, however clicking on the button could remove the chip before it has the chance to stop propagation.

Fixes angular#8771.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chips): event propagation not stopped by remove button crisbeto/material2
2 participants
@crisbeto @yoonjesung