Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): add horizontal fallback positions to the connected overlay defaults #8689

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 28, 2017

Adds horizontal fallbacks to the CdkConnectedOverlay directive default positions.

Fixes #8318.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 28, 2017
@willshowell
Copy link
Contributor

Fixes #8318

…lay defaults

Adds horizontal fallbacks to the `CdkConnectedOverlay` directive default positions.

Fixes angular#8318.
@crisbeto crisbeto force-pushed the 8318/overlay-directive-defaults branch from 4cb6d87 to aa422c5 Compare November 28, 2017 20:39
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 28, 2017
@tinayuangao tinayuangao merged commit e939ea7 into angular:master Dec 1, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdkConnectedOverlay default positions don't have horizontal fallbacks
5 participants