Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In linear steppers, steps with pending components should not be considered completed #8645

Closed
olivierlemasle opened this issue Nov 25, 2017 · 1 comment · Fixed by #8646
Closed
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@olivierlemasle
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the expected behavior?

In a linear stepper, going to the next step should require that no components of the step are in invalid or pending states (i.e. all components are valid or disabled). Pending components (i.e. components with async validators pending) should block the step.

What is the current behavior?

Pending components do not block the step.

What are the steps to reproduce?

Example: http://plnkr.co/edit/aFMUy13jRinsHHudFltm?p=preview

The first step has a single input component, with two validators:

  • validators.required (sync)
  • a custom async validator, validating that the input is not bob, but with a 2 seconds delay (to mock a remote check)

Type "bob", wait a few seconds for the check to complete, then try to go the second step. It will block: first step is required.

Change value to "". Then type "bob" again, but go the second step while validation is pending. The stepper is not blocked.

What is the use-case or motivation for changing an existing behavior?

In a linear stepper, validation is expected to be required.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 5.0.3, Material 5.0.0-rc1

@mmalerba mmalerba added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 28, 2017
crisbeto pushed a commit to crisbeto/material2 that referenced this issue Dec 1, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants