Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu): add md-menu standalone component #855

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Conversation

kara
Copy link
Contributor

@kara kara commented Jul 14, 2016

This is a small PR to add styling for the basic menu component.

TODO:

  • menu toggle that will show/hide the menu
  • keyboard navigation
  • aria attributes

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jul 14, 2016
@kara kara force-pushed the master branch 3 times, most recently from e5d7efd to d26ead4 Compare July 14, 2016 01:04
* This mixin overrides default button styles like the gray background,
* the border, and the outline.
*/
@mixin md-button-reset {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of want to stop putting stuff into mixin.scss since it's too much of a random grab-bag. Can we add a button-mixins file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good call. Added.

@jelbourn
Copy link
Member

Not sure what's up with the CI checks

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jul 14, 2016
@kara
Copy link
Contributor Author

kara commented Jul 14, 2016

@jelbourn Comments should be addressed. The CLA thing is weird but it seems like it resolved itself?

@kara kara force-pushed the master branch 2 times, most recently from 3770bab to bd2778a Compare July 14, 2016 16:52
@jelbourn
Copy link
Member

LGTM

@kara kara added the action: merge The PR is ready for merge by the caretaker label Jul 14, 2016
@kara kara merged commit e324e47 into angular:master Jul 14, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants