Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The style property 'display' of the mat-paginator component should set to 'display: block' by default #8454

Closed
MJomaa opened this issue Nov 15, 2017 · 1 comment · Fixed by #8455
Assignees
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@MJomaa
Copy link

MJomaa commented Nov 15, 2017

Bug, feature request, or proposal:

Proposal

What is the expected behavior?

The mat-paginator is usually used above or under a collection, table, etc.
Therefore display: block; should be used to render correctly its width and borders if modified externally by the .mat-paginator selector.

What is the current behavior?

There is no display style property defined on the host.

What are the steps to reproduce?

You can actually see that the style property is missing in the source code:
https://github.com/angular/material2/blob/master/src/lib/paginator/paginator.scss
https://github.com/angular/material2/blob/master/src/lib/paginator/paginator.ts

What is the use-case or motivation for changing an existing behavior?

The mat-paginator is usually used above or under a collection, table, etc.
Therefore display: block; should be used to render correctly its width and borders if modified externally by a .mat-paginator selector.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular: 5.0.0
Material2: 5.0.0-rc0
OS: Debian 8
TypeScript: 2.4.2
Browser: Chrome, Firefox, etc.

Is there anything else we should know?

No

crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 15, 2017
Makes the `mat-paginator` a block-level element by default, instead of inline.

Fixes angular#8454.
@crisbeto crisbeto self-assigned this Nov 15, 2017
@crisbeto crisbeto added the P4 A relatively minor issue that is not relevant to core functions label Nov 28, 2017
andrewseguin pushed a commit that referenced this issue Dec 13, 2017
Makes the `mat-paginator` a block-level element by default, instead of inline.

Fixes #8454.
andrewseguin pushed a commit to andrewseguin/components that referenced this issue Dec 19, 2017
Makes the `mat-paginator` a block-level element by default, instead of inline.

Fixes angular#8454.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants